[PATCH 1/12] arch/powerpc/kernel: Add missing unlock
in [Kernel]
|
Prev: [PATCH 12/12] kernel/trace: Add missing unlock
Next: [PATCH 2/12] arch/s390/kernel: Add missing unlock
From: Julia Lawall on 29 Mar 2010 11:40 From: Julia Lawall <julia(a)diku.dk> Add an unlock before exiting the function. A simplified version of the semantic patch that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @r exists@ expression E1; identifier f; @@ f (...) { <+... * spin_lock_irq (E1,...); .... when != E1 * return ...; ....+> } // </smpl> Signed-off-by: Julia Lawall <julia(a)diku.dk> --- arch/powerpc/kernel/vio.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/arch/powerpc/kernel/vio.c b/arch/powerpc/kernel/vio.c index 77f6421..2ca69fa 100644 --- a/arch/powerpc/kernel/vio.c +++ b/arch/powerpc/kernel/vio.c @@ -644,8 +644,10 @@ void vio_cmo_set_dev_desired(struct vio_dev *viodev, size_t desired) found = 1; break; } - if (!found) + if (!found) { + spin_unlock_irqrestore(&vio_cmo.lock, flags); return; + } /* Increase/decrease in desired device entitlement */ if (desired >= viodev->cmo.desired) { -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |