Prev: [PATCH] staging: spectra needs <linux/slab.h>
Next: [PATCH] cgroup_freezer: Freezing and task move race fix
From: Kevin Wells on 10 Aug 2010 15:50
Hi Alessandro,

Thanks for helping to review this.

>
> > +
> > + retval = request_irq(rtc->irq, lpc32xx_rtc_alarm_interrupt,
> > + IRQF_DISABLED, "rtcalarm", rtc);
> > + if (retval < 0) {
> > + dev_err(&pdev->dev, "Can't request interrupt\n");
> > + goto err_free_irq;
> > + }
>
> if the driver can work without the alarm irq you
> can convert this to a non fatal warning.
>
> having an rtc without alarms is much better than having none.
>

Good suggestion. I'll change this.

> --
>
> Best regards,
>
> Alessandro Zummo,
> Tower Technologies - Torino, Italy
>
> http://www.towertech.it
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH] staging: spectra needs <linux/slab.h>
Next: [PATCH] cgroup_freezer: Freezing and task move race fix