Prev: [PATCH 3/3] posix_timer: move copy_to_user(created_timer_id) down in timer_create
Next: How to make sure that the process does not encounter the PAGE FAULT after the thread running
From: Andrey Vagin on 17 May 2010 09:50
currently "The next step is hard to back out if there is an error." comment is not right,
release_posix_timer() does put_pid().

Signed-off-by: Andrey Vagin <avagin(a)openvz.org>
---
kernel/posix-timers.c | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/kernel/posix-timers.c b/kernel/posix-timers.c
index 00d1fda..5555e7c 100644
--- a/kernel/posix-timers.c
+++ b/kernel/posix-timers.c
@@ -563,10 +563,6 @@ SYSCALL_DEFINE3(timer_create, const clockid_t, which_clock,
if (error)
goto out;

- /*
- * return the timer_id now. The next step is hard to
- * back out if there is an error.
- */
if (copy_to_user(created_timer_id,
&new_timer_id, sizeof (new_timer_id))) {
error = -EFAULT;
--
1.6.6

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH 3/3] posix_timer: move copy_to_user(created_timer_id) down in timer_create
Next: How to make sure that the process does not encounter the PAGE FAULT after the thread running