Prev: [PATCH 02/25] cpufreq: Convert pci_table entries to PCI_VDEVICE (if PCI_ANY_ID is used)
Next: [PATCH 6/8] xfs: fix unsigned underflow
From: Kulikov Vasiliy on 15 Jul 2010 14:50
divider_u71 is unsigned, so this check is buggy:
if (divider_u71 - 2 > 255 || divider_u71 - 2 < 0)

If divider_u71 is 0 or 1 both checks are lying.
So, it does not produce a buggy answer, but it is confusing.

Signed-off-by: Kulikov Vasiliy <segooon(a)gmail.com>
---
arch/arm/mach-tegra/tegra2_clocks.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-tegra/tegra2_clocks.c b/arch/arm/mach-tegra/tegra2_clocks.c
index 4261632..64df5b4 100644
--- a/arch/arm/mach-tegra/tegra2_clocks.c
+++ b/arch/arm/mach-tegra/tegra2_clocks.c
@@ -149,7 +149,7 @@ static int clk_div71_get_divider(struct clk *c, unsigned long rate)

divider_u71 = DIV_ROUND_UP(c->rate * 2, rate);

- if (divider_u71 - 2 > 255 || divider_u71 - 2 < 0)
+ if (divider_u71 > 2 + 255 || divider_u71 < 2)
return -EINVAL;

return divider_u71 - 2;
--
1.7.0.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH 02/25] cpufreq: Convert pci_table entries to PCI_VDEVICE (if PCI_ANY_ID is used)
Next: [PATCH 6/8] xfs: fix unsigned underflow