Prev: [PATCH 5/9] drivers/spi: Drop unnecessary null test
Next: [PATCH 7/9] drivers/staging: Drop unnecessary null test
From: Julia Lawall on 3 Aug 2010 17:40
From: Julia Lawall <julia(a)diku.dk>

list_for_each_entry_safe binds its first argument to a non-null value, and
thus any null test on the value of that argument is superfluous.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
iterator I;
expression x,E;
@@

I(x,...) { <...
- (x != NULL) &&
E
...> }
// </smpl>

Signed-off-by: Julia Lawall <julia(a)diku.dk>

---
drivers/scsi/qla2xxx/qla_os.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
index ff2172d..2b0e6ef 100644
--- a/drivers/scsi/qla2xxx/qla_os.c
+++ b/drivers/scsi/qla2xxx/qla_os.c
@@ -2348,7 +2348,7 @@ qla2x00_remove_one(struct pci_dev *pdev)
ha = base_vha->hw;

list_for_each_entry_safe(vha, temp, &ha->vp_list, list) {
- if (vha && vha->fc_vport)
+ if (vha->fc_vport)
fc_vport_terminate(vha->fc_vport);
}

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH 5/9] drivers/spi: Drop unnecessary null test
Next: [PATCH 7/9] drivers/staging: Drop unnecessary null test