[PATCH 18/24] lmb: Add reserve_lmb_overlap_ok()
in [Kernel]
|
Prev: [PATCH 08/24] lmb: Add find_lmb_area_size()
Next: [PATCH 23/24] x86, lmb: Use lmb_memory_size()/lmb_free_memory_size() to get correct dma_reserve
From: Yinghai Lu on 26 Mar 2010 18:30 Some areas from firmware could be reserved several times from different callers. If these area are overlapped, We may have overlapped entries in lmb.reserved. Try to free the area at first, before rerserve them again. Signed-off-by: Yinghai Lu <yinghai(a)kernel.org> --- include/linux/lmb.h | 1 + mm/lmb.c | 27 +++++++++++++++++++++++++-- 2 files changed, 26 insertions(+), 2 deletions(-) diff --git a/include/linux/lmb.h b/include/linux/lmb.h index 285f287..1e11fe0 100644 --- a/include/linux/lmb.h +++ b/include/linux/lmb.h @@ -85,6 +85,7 @@ lmb_end_pfn(struct lmb_region *type, unsigned long region_nr) } void reserve_lmb(u64 start, u64 end, char *name); +void reserve_lmb_overlap_ok(u64 start, u64 end, char *name); void free_lmb(u64 start, u64 end); void add_lmb_memory(u64 start, u64 end); u64 __find_lmb_area(u64 ei_start, u64 ei_last, u64 start, u64 end, diff --git a/mm/lmb.c b/mm/lmb.c index 0dab3b6..20ab927 100644 --- a/mm/lmb.c +++ b/mm/lmb.c @@ -615,6 +615,12 @@ void __init add_lmb_memory(u64 start, u64 end) lmb_add(start, end - start); } +static void __init __reserve_lmb(u64 start, u64 end, char *name) +{ + __check_and_double_region_array(&lmb.reserved, &lmb_reserved_region[0], start, end); + lmb_reserve(start, end - start); +} + void __init reserve_lmb(u64 start, u64 end, char *name) { if (start == end) @@ -623,8 +629,25 @@ void __init reserve_lmb(u64 start, u64 end, char *name) if (WARN_ONCE(start > end, "reserve_lmb: wrong range [%#llx, %#llx]\n", start, end)) return; - __check_and_double_region_array(&lmb.reserved, &lmb_reserved_region[0], start, end); - lmb_reserve(start, end - start); + __reserve_lmb(start, end, name); +} + +/* + * Could be used to avoid having overlap entries in lmb.reserved.region. + * Don't need to use it with area that is from find_lmb_area() + * Only use it for the area that fw hidden area. + */ +void __init reserve_lmb_overlap_ok(u64 start, u64 end, char *name) +{ + if (start == end) + return; + + if (WARN_ONCE(start > end, "reserve_lmb_overlap_ok: wrong range [%#llx, %#llx]\n", start, end)) + return; + + /* Free that region at first */ + lmb_free(start, end - start); + __reserve_lmb(start, end, name); } void __init free_lmb(u64 start, u64 end) -- 1.6.4.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |