[PATCH 19/29] move s3c241xfb's probe function to .devinit.text
in [Kernel]
|
Prev: [PATCH 07/29] move efifb's probe function to .devinit.text
Next: NFS_FSCACHE still depends on EXPERIMENTAL?
From: Uwe Kleine-König on 23 Jan 2010 15:50 Pointers to s3c2410fb_probe and s3c2412fb_probe are passed to the core via platform_driver_register and so the functions must not disappear when the .init sections are discarded. Otherwise (if also having HOTPLUG=y) unbinding and binding a device to one of the drivers via sysfs will result in an oops as does a device being registered late. An alternative to this patch is using platform_driver_probe instead of platform_driver_register plus removing the pointer to the probe function from the struct platform_driver. Signed-off-by: Uwe Kleine-König <u.kleine-koenig(a)pengutronix.de> Cc: Russell King <rmk+kernel(a)arm.linux.org.uk> Cc: Ben Dooks <ben-linux(a)fluff.org> Cc: Arnaud Patard <arnaud.patard(a)rtp-net.org> Cc: Krzysztof Helt <krzysztof.h1(a)wp.pl> Cc: Andrew Morton <akpm(a)linux-foundation.org> Cc: Antonino Daplas <adaplas(a)pol.net> Cc: Vincent Sanders <vince(a)simtec.co.uk> --- drivers/video/s3c2410fb.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/video/s3c2410fb.c b/drivers/video/s3c2410fb.c index aac6612..2b094de 100644 --- a/drivers/video/s3c2410fb.c +++ b/drivers/video/s3c2410fb.c @@ -1004,12 +1004,12 @@ dealloc_fb: return ret; } -static int __init s3c2410fb_probe(struct platform_device *pdev) +static int __devinit s3c2410fb_probe(struct platform_device *pdev) { return s3c24xxfb_probe(pdev, DRV_S3C2410); } -static int __init s3c2412fb_probe(struct platform_device *pdev) +static int __devinit s3c2412fb_probe(struct platform_device *pdev) { return s3c24xxfb_probe(pdev, DRV_S3C2412); } -- 1.6.6 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |