Prev: [PATCH][RT] futex: protect against pi_blocked_on corruption during requeue PI
Next: drivers/media: Remove unnecessary casts of private_data
From: Joel Becker on 13 Jul 2010 04:20
On Mon, Jul 12, 2010 at 10:00:10PM -0700, Patrick J. LoPresti wrote:
> On Mon, Jul 12, 2010 at 9:46 PM, Andreas Dilger <adilger(a)dilger.ca> wrote:
> > On 2010-07-12, at 19:08, Patrick J. LoPresti wrote:
> >> Are you suggesting I need to do this before my patch is accepted at
> >> all? �Or is this a refactoring that can happen later?
> > I'm just suggesting it should be done at some point. �I thought it would be better to do it first, rather than add yet another copy of this code. �That said, I hate to block useful fixes because of cleanup (and I have no control over OCFS2 anyway :-). �However, I've found that once the fix is in people usually forget (or become too busy) to do the cleanup and it just lingers on unseen.
> I hear you.
> I do not object to factoring out the basic addressability test and
> using it in my patch, leaving it for others -- like yourself :-) -- to
> modify other file systems to invoke it.
I think you should modify ext3 and xfs, as they clearly are
partaking of this functionality. I'll happily review it for you. Put
the call in fs/libfs.c. Call it generic_check_addressable(struct
"The only way to get rid of a temptation is to yield to it."
- Oscar Wilde
Consulting Software Developer
Phone: (650) 506-8127
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/