[PATCH 2.6.35-rc1] net: vmxnet3 fixes [4/5] Do not reset when the device is not opened
in [Kernel]
|
Prev: [PATCH 2.6.35-rc1] net: vmxnet3 fixes [3/5] Initialize link state at probe time
Next: [PATCH v2] firewire: cdev: check write quadlet request length to avoid buffer overflow
From: Shreyas Bhatewara on 7 Jul 2010 05:40 commit bc8b3f0b3978d3c0a201926b2e2bd5c732e0352e Author: Shreyas Bhatewara <sbhatewara(a)vmware.com> Date: Tue Jul 6 17:00:48 2010 -0700 No reset when the device is not opened If a reset is scheduled, and the device goes thru close and open, it may happen that reset and open may run in parallel. The reset code now bails out if the device is not opened. Signed-off-by: Ronghua Zang <ronghua(a)vmware.com> Signed-off-by: Matthieu Bucchianeri <matthieu(a)vmware.com> Signed-off-by: Shreyas Bhatewara <sbhatewara(a)vmware.com> --- diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c b/drivers/net/vmxnet3/vmxnet3_drv.c index 31a838f..01a5bb7 100644 --- a/drivers/net/vmxnet3/vmxnet3_drv.c +++ b/drivers/net/vmxnet3/vmxnet3_drv.c @@ -2417,8 +2417,9 @@ vmxnet3_reset_work(struct work_struct *data) if (test_and_set_bit(VMXNET3_STATE_BIT_RESETTING, &adapter->state)) return; - /* if the device is closed, we must leave it alone */ - if (netif_running(adapter->netdev)) { + /* if the device is closed or is being opened, we must leave it alone */ + if (netif_running(adapter->netdev) && + (adapter->netdev->flags & IFF_UP)) { printk(KERN_INFO "%s: resetting\n", adapter->netdev->name); vmxnet3_quiesce_dev(adapter); vmxnet3_reset_dev(adapter); diff --git a/drivers/net/vmxnet3/vmxnet3_int.h b/drivers/net/vmxnet3/vmxnet3_int.h index 5c94afa..8e1f704 100644 --- a/drivers/net/vmxnet3/vmxnet3_int.h +++ b/drivers/net/vmxnet3/vmxnet3_int.h @@ -68,10 +68,10 @@ /* * Version numbers */ -#define VMXNET3_DRIVER_VERSION_STRING "1.0.10.0-k" +#define VMXNET3_DRIVER_VERSION_STRING "1.0.11.0-k" /* a 32-bit int, each byte encode a verion number in VMXNET3_DRIVER_VERSION */ -#define VMXNET3_DRIVER_VERSION_NUM 0x01000A00 +#define VMXNET3_DRIVER_VERSION_NUM 0x01000B00 /* -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |