[PATCH 2/6] procfs: Use generic_file_llseek in /proc/kcore
in [Kernel]
|
Prev: [PATCH 3/6] procfs: Use generic_file_llseek in /proc/kmsg
Next: [PATCH 6/6] procfs: Kill the bkl in ioctl
From: Frederic Weisbecker on 30 Mar 2010 02:30 /proc/kcore has no llseek and then falls down to use default_llseek. This is racy against read_kcore() that directly manipulates fpos but it doesn't hold the bkl there so using it in llseek doesn't protect anything. Let's use generic_file_llseek() instead. Signed-off-by: Frederic Weisbecker <fweisbec(a)gmail.com> Cc: Arnd Bergmann <arnd(a)arndb.de> Cc: Thomas Gleixner <tglx(a)linutronix.de> Cc: Andrew Morton <akpm(a)linux-foundation.org> Cc: Ingo Molnar <mingo(a)elte.hu> Cc: John Kacur <jkacur(a)redhat.com> Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu(a)jp.fujitsu.com> Cc: Al Viro <viro(a)ZenIV.linux.org.uk> --- fs/proc/kcore.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/fs/proc/kcore.c b/fs/proc/kcore.c index a44a789..da21060 100644 --- a/fs/proc/kcore.c +++ b/fs/proc/kcore.c @@ -557,6 +557,7 @@ static int open_kcore(struct inode *inode, struct file *filp) static const struct file_operations proc_kcore_operations = { .read = read_kcore, .open = open_kcore, + .llseek = generic_file_llseek, }; #ifdef CONFIG_MEMORY_HOTPLUG -- 1.6.2.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |