[PATCH 28/28] debug_core: Turn off tracing while in the debugger
in [Kernel]
|
Prev: [PATCH 01/28] Move kernel/kgdb.c to kernel/debug/debug_core.c
Next: [PATCH 05/28] kgdb,sh: update superh kgdb exception handling
From: Jason Wessel on 25 Feb 2010 16:30 The kernel debugger should turn off kernel tracing any time the debugger is active and restore it on resume. CC: Steven Rostedt <rostedt(a)goodmis.org> Signed-off-by: Jason Wessel <jason.wessel(a)windriver.com> --- kernel/debug/debug_core.c | 8 ++++++++ 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/kernel/debug/debug_core.c b/kernel/debug/debug_core.c index ed42d9e..3d36d9e 100644 --- a/kernel/debug/debug_core.c +++ b/kernel/debug/debug_core.c @@ -474,6 +474,7 @@ static int kgdb_cpu_enter(struct kgdb_state *ks, struct pt_regs *regs) int sstep_tries = 100; int error; int i, cpu; + int trace_on = 0; acquirelock: /* * Interrupts will be restored by the 'trap return' code, except when @@ -518,6 +519,8 @@ return_normal: */ if (arch_kgdb_ops.correct_hw_break) arch_kgdb_ops.correct_hw_break(); + if (trace_on) + tracing_on(); atomic_set(&cpu_in_kgdb[cpu], 0); touch_softlockup_watchdog_sync(); clocksource_touch_watchdog(); @@ -592,6 +595,9 @@ return_normal: kgdb_single_step = 0; kgdb_contthread = current; exception_level = 0; + trace_on = tracing_is_on(); + if (trace_on) + tracing_off(); while (1) { cpu_master_loop: @@ -645,6 +651,8 @@ kgdb_restore: else kgdb_sstep_pid = 0; } + if (trace_on) + tracing_on(); /* Free kgdb_active */ atomic_set(&kgdb_active, -1); touch_softlockup_watchdog_sync(); -- 1.6.4.rc1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |