Prev: [PATCH 26/42] drivers/spi/amba-pl022.c: Adjust confusing if indentation
Next: [PATCH 39/42] drivers/mfd: Adjust confusing if indentation
From: Julia Lawall on 5 Aug 2010 16:40
From: Julia Lawall <julia(a)diku.dk>

Outdent the code following the if.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@r disable braces4@
position p1,p2;
statement S1,S2;
@@

(
if (...) { ... }
|
if (...) S1(a)p1 S2(a)p2
)

@script:python@
p1 << r.p1;
p2 << r.p2;
@@

if (p1[0].column == p2[0].column):
cocci.print_main("branch",p1)
cocci.print_secs("after",p2)
// </smpl>

Signed-off-by: Julia Lawall <julia(a)diku.dk>

---
This patch doesn't change the semantics of the code. But it might not be
what is intended.

drivers/scsi/st.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/scsi/st.c b/drivers/scsi/st.c
index 24211d0..9c57a50 100644
--- a/drivers/scsi/st.c
+++ b/drivers/scsi/st.c
@@ -4166,9 +4166,9 @@ out_free_tape:
if (STm->cdevs[j]) {
if (cdev == STm->cdevs[j])
cdev = NULL;
- device_destroy(st_sysfs_class,
- MKDEV(SCSI_TAPE_MAJOR,
- TAPE_MINOR(i, mode, j)));
+ device_destroy(st_sysfs_class,
+ MKDEV(SCSI_TAPE_MAJOR,
+ TAPE_MINOR(i, mode, j)));
cdev_del(STm->cdevs[j]);
}
}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH 26/42] drivers/spi/amba-pl022.c: Adjust confusing if indentation
Next: [PATCH 39/42] drivers/mfd: Adjust confusing if indentation