[PATCH 3/3] powerpc-silence-xics_migrate_irqs_away-during-cpu-offline
in [Kernel]
|
Prev: 2.6.35 Regression: Ages spent discarding blocks that weren't used!
Next: [PATCH 1/3] powerpc-enable-preemption-before-cpu_die
From: Darren Hart on 5 Aug 2010 00:30 From: Signed-off-by: Darren Hart <dvhltc(a)us.ibm.com> All IRQs are migrated away from a CPU that is being offlined so the following messages suggest a problem when the system is behaving as designed: IRQ 262 affinity broken off cpu 1 IRQ 17 affinity broken off cpu 0 IRQ 18 affinity broken off cpu 0 IRQ 19 affinity broken off cpu 0 IRQ 256 affinity broken off cpu 0 IRQ 261 affinity broken off cpu 0 IRQ 262 affinity broken off cpu 0 Don't print these messages when the CPU is not online. Signed-off-by: Darren Hart <dvhltc(a)us.ibm.com> Acked-by: Will Schmidt <will_schmidt(a)vnet.ibm.com> Cc: Thomas Gleixner <tglx(a)linutronix.de> Cc: Nathan Fontenot <nfont(a)austin.ibm.com> Cc: Robert Jennings <rcj(a)linux.vnet.ibm.com> Cc: Brian King <brking(a)linux.vnet.ibm.com> --- arch/powerpc/platforms/pseries/xics.c | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/platforms/pseries/xics.c b/arch/powerpc/platforms/pseries/xics.c index f19d194..8d0b0b1 100644 --- a/arch/powerpc/platforms/pseries/xics.c +++ b/arch/powerpc/platforms/pseries/xics.c @@ -930,8 +930,10 @@ void xics_migrate_irqs_away(void) if (xics_status[0] != hw_cpu) goto unlock; - printk(KERN_WARNING "IRQ %u affinity broken off cpu %u\n", - virq, cpu); + /* This is expected during cpu offline. */ + if (cpu_online(cpu)) + printk(KERN_WARNING "IRQ %u affinity broken off cpu %u\n", + virq, cpu); /* Reset affinity to all cpus */ cpumask_setall(irq_to_desc(virq)->affinity); -- 1.7.0.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |