[PATCH 3/4] Driver didn't verify the pointers in which it got product information
in [Kernel]
|
Prev: RTC: Add JZ4740 RTC driver
Next: [PATCH 1/4] Acerhdf: Added new BIOS versions for Acer 1410 and 1810xx and Packard Bell
From: Peter Feuerer on 19 Jun 2010 08:00 [PATCH 3/4] Driver didn't verify the pointers in which it got product information back from DMI; on QEMU one of the pointers came back null, which made the driver crash and subsequently caused a kernel panic. From: Rahul Chaturvedi <rkc(a)chromium.org> Signed-off-by: Rahul Chaturvedi <rkc(a)chromium.org> Signed-off-by: Peter Feuerer <peter(a)piie.net> Cc: Borislav Petkov <petkovbb(a)gmail.com> Cc: Andreas Mohr <andi(a)lisas.de> Cc: Len Brown <lenb(a)kernel.org> --- drivers/platform/x86/acerhdf.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/drivers/platform/x86/acerhdf.c b/drivers/platform/x86/acerhdf.c index 9226838..6abd3f1 100644 --- a/drivers/platform/x86/acerhdf.c +++ b/drivers/platform/x86/acerhdf.c @@ -524,6 +524,10 @@ static int acerhdf_check_hardware(void) version = dmi_get_system_info(DMI_BIOS_VERSION); product = dmi_get_system_info(DMI_PRODUCT_NAME); + if (!vendor || !version || !product) { + pr_err("error getting hardware information\n"); + return -EINVAL; + } pr_info("Acer Aspire One Fan driver, v.%s\n", DRV_VER); -- 1.7.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |