[PATCH 5/5] drivers/serial: Return -ENOMEM on memory allocation failure
in [Kernel]
|
Prev: Documentation about RS485 serial communications
Next: [PATCH 1/5] drivers/usb/gadget: Return -ENOMEM on memory allocation failure
From: Julia Lawall on 11 Aug 2010 06:20 From: Julia Lawall <julia(a)diku.dk> In this code, 0 is returned on memory allocation failure, even though other failures return -ENOMEM or other similar values. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ expression ret; expression x,e1,e2,e3; @@ ret = 0 .... when != ret = e1 *x = \(kmalloc\|kcalloc\|kzalloc\)(...) .... when != ret = e2 if (x == NULL) { ... when != ret = e3 return ret; } // </smpl> Signed-off-by: Julia Lawall <julia(a)diku.dk> --- I believe this code also leaks earlier instances of port, which are only referenced by card_ptr, which is freed in the error handling code at the end of the function. A lot of operations are done on port on each iteration, however, so I'm not sure whether it is good enough to just free them. Perhaps there is some way to call ioc3uart_remove? drivers/serial/ioc3_serial.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/serial/ioc3_serial.c b/drivers/serial/ioc3_serial.c index 93de907..800c546 100644 --- a/drivers/serial/ioc3_serial.c +++ b/drivers/serial/ioc3_serial.c @@ -2044,6 +2044,7 @@ ioc3uart_probe(struct ioc3_submodule *is, struct ioc3_driver_data *idd) if (!port) { printk(KERN_WARNING "IOC3 serial memory not available for port\n"); + ret = -ENOMEM; goto out4; } spin_lock_init(&port->ip_lock); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |