Prev: [PATCH 0/6 v6][RFC] jbd[2]: enhance fsync performance when using CFQ
Next: X:2252 conflicting memory types 40000000-48000000 uncached-minus<->write-combining
From: Jeff Moyer on 2 Jul 2010 16:10
In trying to get fsync-ing processes to perform as well under CFQ as they
do in deadline, I found (with the current blk_yield approach) that it was
necessary to get rid of the RQ_NOIDLE flag for WRITE_SYNC I/O. Instead,
we do explicit yielding of the I/O scheduler.

Comments, as always, are greatly appreciated.

Cheers,
Jeff

Signed-off-by: Jeff Moyer <jmoyer(a)redhat.com>
---
include/linux/fs.h | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/fs.h b/include/linux/fs.h
index 471e1ff..da34297 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -152,12 +152,12 @@ struct inodes_stat_t {
#define SWRITE 3 /* for ll_rw_block() - wait for buffer lock */
#define READ_SYNC (READ | (1 << BIO_RW_SYNCIO) | (1 << BIO_RW_UNPLUG))
#define READ_META (READ | (1 << BIO_RW_META))
-#define WRITE_SYNC_PLUG (WRITE | (1 << BIO_RW_SYNCIO) | (1 << BIO_RW_NOIDLE))
+#define WRITE_SYNC_PLUG (WRITE | (1 << BIO_RW_SYNCIO))
#define WRITE_SYNC (WRITE_SYNC_PLUG | (1 << BIO_RW_UNPLUG))
#define WRITE_ODIRECT_PLUG (WRITE | (1 << BIO_RW_SYNCIO))
#define WRITE_META (WRITE | (1 << BIO_RW_META))
#define SWRITE_SYNC_PLUG \
- (SWRITE | (1 << BIO_RW_SYNCIO) | (1 << BIO_RW_NOIDLE))
+ (SWRITE | (1 << BIO_RW_SYNCIO))
#define SWRITE_SYNC (SWRITE_SYNC_PLUG | (1 << BIO_RW_UNPLUG))
#define WRITE_BARRIER (WRITE | (1 << BIO_RW_BARRIER))

--
1.6.5.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH 0/6 v6][RFC] jbd[2]: enhance fsync performance when using CFQ
Next: X:2252 conflicting memory types 40000000-48000000 uncached-minus<->write-combining