[PATCH 6/9] viafb: VIA Frame Buffer Device Driver
in [Kernel]
|
Prev: [PATCH 1/9] viafb: VIA Frame Buffer Device Driver
Next: [PATCH 3/9] viafb: VIA Frame Buffer Device Driver
From: Alan Cox on 7 May 2008 11:40 > +void delays(int count); > +void i2cWriteSdaScl(u8 sda, u8 scl); > +void i2cWriteScl(u8 scl); > +void i2cReadSdaScl(u8 *pSda, u8 *pScl); Style is good, code looks clean One big thing that needs fixing here is the function names. If the driver gets linked into the kernel then the symbols become global - and names like enableGPIO are asking for clashes. The viafb code is fine as it uses viafb_ as the function names. Possibly the helper functions should doo something similar. We also have a generic i2c layer that might be usable but that is something that could be addressed in the future and isn't really an important detail. > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |