Prev: hid: update gfp/slab.h includes
Next: [PATCH 0/14] Start coping gsis < 16 that are not isa irqs.
From: David Howells on 29 Mar 2010 19:10
From: Mathieu Desnoyers <mathieu.desnoyers(a)efficios.com>

Fix a memory leak on an OOM condition in prepare_usermodehelper_creds().

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers(a)efficios.com>
Signed-off-by: David Howells <dhowells(a)redhat.com>
---

kernel/cred.c | 6 +++++-
1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/kernel/cred.c b/kernel/cred.c
index 1ed8ca1..1b1129d 100644
--- a/kernel/cred.c
+++ b/kernel/cred.c
@@ -364,7 +364,7 @@ struct cred *prepare_usermodehelper_creds(void)

new = kmem_cache_alloc(cred_jar, GFP_ATOMIC);
if (!new)
- return NULL;
+ goto free_tgcred;

kdebug("prepare_usermodehelper_creds() alloc %p", new);

@@ -397,6 +397,10 @@ struct cred *prepare_usermodehelper_creds(void)

error:
put_cred(new);
+free_tgcred:
+#ifdef CONFIG_KEYS
+ kfree(tgcred);
+#endif
return NULL;
}


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: hid: update gfp/slab.h includes
Next: [PATCH 0/14] Start coping gsis < 16 that are not isa irqs.