Prev: ACPI: Remove repeated registered as cooling_device messages
Next: dm: sysfs add empty release function to avoid debug warning
From: Roel Kluin on 15 Dec 2009 19:40
mtd->writesize and len are unsigned so the test does not work.

Signed-off-by: Roel Kluin <roel.kluin(a)gmail.com>
---
you can test this with:

#include <stdio.h>

int main()
{
int c = 1, d = 1;
unsigned a = 30;
unsigned b = 10;

if ((b * c) - (d + a) < 0)
printf("good\n");
else
printf("bad\n");
return 0;
}


diff --git a/drivers/mtd/onenand/onenand_base.c b/drivers/mtd/onenand/onenand_base.c
index ff66e43..cbe2711 100644
--- a/drivers/mtd/onenand/onenand_base.c
+++ b/drivers/mtd/onenand/onenand_base.c
@@ -2725,7 +2725,7 @@ static int onenand_otp_walk(struct mtd_info *mtd, loff_t from, size_t len,
}

/* Check User/Factory boundary */
- if (((mtd->writesize * otp_pages) - (from + len)) < 0)
+ if (mtd->writesize * otp_pages < from + len)
return 0;

onenand_get_device(mtd, FL_OTPING);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: ACPI: Remove repeated registered as cooling_device messages
Next: dm: sysfs add empty release function to avoid debug warning