From: Takashi Iwai on
At Thu, 4 Mar 2010 19:37:52 +0800,
Wei Ni wrote:
>
> Do you mean you will check in my patch first, and then I give you the
> additional patch for adding EXPORT_SYMBOL() in hda_eld.c?

Yes. I need the integration tests first.
Meanwhile, prepare your patch on the top of your current patches.
Feel free to post it at any time.

After that, we can merge Fengguang's patch_hdmi.c change on that.


thanks,

Takashi


> -----Original Message-----
> From: Takashi Iwai [mailto:tiwai(a)suse.de]
> Sent: Thursday, March 04, 2010 7:31 PM
> To: Wei Ni
> Cc: 'Pavel Hofman'; 'alsa-devel'; 'linux-kernel'; 'akpm'
> Subject: Re: [alsa-devel] [PATCH]Support MCP89 and GT21x hdmi audio
>
> At Thu, 4 Mar 2010 19:09:29 +0800,
> Wei Ni wrote:
> >
> > Hi, Takashi
> > I test my patch, it build successful when CONFIG_SND_HDA_*=y.
> > Could you give me your build error messages?
>
> Sorry, it's CONFIG_SND_HDA*=m. Then load two modules, so you'll have
> two identical objects in different modules.
>
> OTOH, if it's no exported symbol, it might coexist. Hmm.
>
> If you get no errors with it, then it's fine as an intermediate state.
> Please give the additional patch on them for further fixes.
>
>
> thanks,
>
> Takashi
>
> >
> > Thanks
> > Wei.
> > nvpublic
> >
> > -----Original Message-----
> > From: Takashi Iwai [mailto:tiwai(a)suse.de]
> > Sent: Thursday, March 04, 2010 6:57 PM
> > To: Wei Ni
> > Cc: 'Pavel Hofman'; 'alsa-devel'; 'linux-kernel'; 'akpm'
> > Subject: Re: [alsa-devel] [PATCH]Support MCP89 and GT21x hdmi audio
> >
> > At Thu, 4 Mar 2010 18:46:59 +0800,
> > Wei Ni wrote:
> > >
> > > Hi, Takashi
> > > I think we can submit my patch first,
> >
> > But your patch breaks the build when CONFIG_SND_HDA_*=y.
> > So, it should be fixed in your patch.
> >
> >
> > thanks,
> >
> > Takashi
> >
> > > then generate another patch
> > > to add EXPORT_SYMBOL() in hda_eld.c, and change Makefile to remove
> > > hda_eld.o from snd-hda-codec-xxhdmi-objs.
> > >
> > > Thanks
> > > Wei.
> > > nvpublic
> > >
> > > -----Original Message-----
> > > From: Takashi Iwai [mailto:tiwai(a)suse.de]
> > > Sent: Thursday, March 04, 2010 5:47 PM
> > > To: Wei Ni
> > > Cc: 'Pavel Hofman'; 'alsa-devel'; 'linux-kernel'; 'akpm'
> > > Subject: Re: [alsa-devel] [PATCH]Support MCP89 and GT21x hdmi audio
> > >
> > > At Thu, 4 Mar 2010 10:21:39 +0800,
> > > Wei Ni wrote:
> > > >
> > > > Hi, Takashi
> > > > 1. Yes, it can works for all Nvidia controller.
> > >
> > > OK.
> > >
> > > > 2. The hda_eld.o doesn't export any symbols.
> > > > I tried to put hda_eld.o to snd-had-codec-*, and remove had_eldo.o
> > > > from snd-had-codec-intelhdmi-objs, but it will build error. It need
> > > > to modify hda_eld.c to export symbols, it will add many changes.
> > >
> > > Yes, this is unavoidable. Please add EXPORT_SYMBOL()'s
> > > appropriately.
> > >
> > > We can reduce them again once after all HDMI stuff is merged into
> > > one.
> > >
> > >
> > > thanks,
> > >
> > > Takashi
> > >
> >
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Takashi Iwai on
At Thu, 4 Mar 2010 19:46:17 +0800,
Wei Ni wrote:
>
> Ok, I will give you the patch tomorrow.

In the end, I fixed it by myself :)
If you have more other fixes, please take topic/hda branch of sound
git tree as basis.
git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound-2.6.git topic/hda

Fengguang, could you rework your patch later for that version?


thanks,

Takashi

>
>
> -----Original Message-----
> From: Takashi Iwai [mailto:tiwai(a)suse.de]
> Sent: Thursday, March 04, 2010 7:44 PM
> To: Wei Ni
> Cc: 'Pavel Hofman'; 'alsa-devel'; 'linux-kernel'; 'akpm'; Wu Fengguang
> Subject: Re: [alsa-devel] [PATCH]Support MCP89 and GT21x hdmi audio
>
> At Thu, 4 Mar 2010 19:37:52 +0800,
> Wei Ni wrote:
> >
> > Do you mean you will check in my patch first, and then I give you the
> > additional patch for adding EXPORT_SYMBOL() in hda_eld.c?
>
> Yes. I need the integration tests first.
> Meanwhile, prepare your patch on the top of your current patches.
> Feel free to post it at any time.
>
> After that, we can merge Fengguang's patch_hdmi.c change on that.
>
>
> thanks,
>
> Takashi
>
>
> > -----Original Message-----
> > From: Takashi Iwai [mailto:tiwai(a)suse.de]
> > Sent: Thursday, March 04, 2010 7:31 PM
> > To: Wei Ni
> > Cc: 'Pavel Hofman'; 'alsa-devel'; 'linux-kernel'; 'akpm'
> > Subject: Re: [alsa-devel] [PATCH]Support MCP89 and GT21x hdmi audio
> >
> > At Thu, 4 Mar 2010 19:09:29 +0800,
> > Wei Ni wrote:
> > >
> > > Hi, Takashi
> > > I test my patch, it build successful when CONFIG_SND_HDA_*=y.
> > > Could you give me your build error messages?
> >
> > Sorry, it's CONFIG_SND_HDA*=m. Then load two modules, so you'll have
> > two identical objects in different modules.
> >
> > OTOH, if it's no exported symbol, it might coexist. Hmm.
> >
> > If you get no errors with it, then it's fine as an intermediate state.
> > Please give the additional patch on them for further fixes.
> >
> >
> > thanks,
> >
> > Takashi
> >
> > >
> > > Thanks
> > > Wei.
> > > nvpublic
> > >
> > > -----Original Message-----
> > > From: Takashi Iwai [mailto:tiwai(a)suse.de]
> > > Sent: Thursday, March 04, 2010 6:57 PM
> > > To: Wei Ni
> > > Cc: 'Pavel Hofman'; 'alsa-devel'; 'linux-kernel'; 'akpm'
> > > Subject: Re: [alsa-devel] [PATCH]Support MCP89 and GT21x hdmi audio
> > >
> > > At Thu, 4 Mar 2010 18:46:59 +0800,
> > > Wei Ni wrote:
> > > >
> > > > Hi, Takashi
> > > > I think we can submit my patch first,
> > >
> > > But your patch breaks the build when CONFIG_SND_HDA_*=y.
> > > So, it should be fixed in your patch.
> > >
> > >
> > > thanks,
> > >
> > > Takashi
> > >
> > > > then generate another patch
> > > > to add EXPORT_SYMBOL() in hda_eld.c, and change Makefile to remove
> > > > hda_eld.o from snd-hda-codec-xxhdmi-objs.
> > > >
> > > > Thanks
> > > > Wei.
> > > > nvpublic
> > > >
> > > > -----Original Message-----
> > > > From: Takashi Iwai [mailto:tiwai(a)suse.de]
> > > > Sent: Thursday, March 04, 2010 5:47 PM
> > > > To: Wei Ni
> > > > Cc: 'Pavel Hofman'; 'alsa-devel'; 'linux-kernel'; 'akpm'
> > > > Subject: Re: [alsa-devel] [PATCH]Support MCP89 and GT21x hdmi audio
> > > >
> > > > At Thu, 4 Mar 2010 10:21:39 +0800,
> > > > Wei Ni wrote:
> > > > >
> > > > > Hi, Takashi
> > > > > 1. Yes, it can works for all Nvidia controller.
> > > >
> > > > OK.
> > > >
> > > > > 2. The hda_eld.o doesn't export any symbols.
> > > > > I tried to put hda_eld.o to snd-had-codec-*, and remove had_eldo.o
> > > > > from snd-had-codec-intelhdmi-objs, but it will build error. It need
> > > > > to modify hda_eld.c to export symbols, it will add many changes.
> > > >
> > > > Yes, this is unavoidable. Please add EXPORT_SYMBOL()'s
> > > > appropriately.
> > > >
> > > > We can reduce them again once after all HDMI stuff is merged into
> > > > one.
> > > >
> > > >
> > > > thanks,
> > > >
> > > > Takashi
> > > >
> > >
> >
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Wei Ni on
Hi,Takashi
Oh, it's great.
In actually, I have lots of other work to do.

Thanks for your help.
Wei.
nvpublic

-----Original Message-----
From: Takashi Iwai [mailto:tiwai(a)suse.de]
Sent: Thursday, March 04, 2010 11:35 PM
To: Wei Ni
Cc: 'Pavel Hofman'; 'alsa-devel'; 'linux-kernel'; 'akpm'; Wu Fengguang
Subject: Re: [alsa-devel] [PATCH]Support MCP89 and GT21x hdmi audio

At Thu, 4 Mar 2010 19:46:17 +0800,
Wei Ni wrote:
>
> Ok, I will give you the patch tomorrow.

In the end, I fixed it by myself :)
If you have more other fixes, please take topic/hda branch of sound
git tree as basis.
git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound-2.6.git topic/hda

Fengguang, could you rework your patch later for that version?


thanks,

Takashi

>
>
> -----Original Message-----
> From: Takashi Iwai [mailto:tiwai(a)suse.de]
> Sent: Thursday, March 04, 2010 7:44 PM
> To: Wei Ni
> Cc: 'Pavel Hofman'; 'alsa-devel'; 'linux-kernel'; 'akpm'; Wu Fengguang
> Subject: Re: [alsa-devel] [PATCH]Support MCP89 and GT21x hdmi audio
>
> At Thu, 4 Mar 2010 19:37:52 +0800,
> Wei Ni wrote:
> >
> > Do you mean you will check in my patch first, and then I give you the
> > additional patch for adding EXPORT_SYMBOL() in hda_eld.c?
>
> Yes. I need the integration tests first.
> Meanwhile, prepare your patch on the top of your current patches.
> Feel free to post it at any time.
>
> After that, we can merge Fengguang's patch_hdmi.c change on that.
>
>
> thanks,
>
> Takashi
>
>
> > -----Original Message-----
> > From: Takashi Iwai [mailto:tiwai(a)suse.de]
> > Sent: Thursday, March 04, 2010 7:31 PM
> > To: Wei Ni
> > Cc: 'Pavel Hofman'; 'alsa-devel'; 'linux-kernel'; 'akpm'
> > Subject: Re: [alsa-devel] [PATCH]Support MCP89 and GT21x hdmi audio
> >
> > At Thu, 4 Mar 2010 19:09:29 +0800,
> > Wei Ni wrote:
> > >
> > > Hi, Takashi
> > > I test my patch, it build successful when CONFIG_SND_HDA_*=y.
> > > Could you give me your build error messages?
> >
> > Sorry, it's CONFIG_SND_HDA*=m. Then load two modules, so you'll have
> > two identical objects in different modules.
> >
> > OTOH, if it's no exported symbol, it might coexist. Hmm.
> >
> > If you get no errors with it, then it's fine as an intermediate state.
> > Please give the additional patch on them for further fixes.
> >
> >
> > thanks,
> >
> > Takashi
> >
> > >
> > > Thanks
> > > Wei.
> > > nvpublic
> > >
> > > -----Original Message-----
> > > From: Takashi Iwai [mailto:tiwai(a)suse.de]
> > > Sent: Thursday, March 04, 2010 6:57 PM
> > > To: Wei Ni
> > > Cc: 'Pavel Hofman'; 'alsa-devel'; 'linux-kernel'; 'akpm'
> > > Subject: Re: [alsa-devel] [PATCH]Support MCP89 and GT21x hdmi audio
> > >
> > > At Thu, 4 Mar 2010 18:46:59 +0800,
> > > Wei Ni wrote:
> > > >
> > > > Hi, Takashi
> > > > I think we can submit my patch first,
> > >
> > > But your patch breaks the build when CONFIG_SND_HDA_*=y.
> > > So, it should be fixed in your patch.
> > >
> > >
> > > thanks,
> > >
> > > Takashi
> > >
> > > > then generate another patch
> > > > to add EXPORT_SYMBOL() in hda_eld.c, and change Makefile to remove
> > > > hda_eld.o from snd-hda-codec-xxhdmi-objs.
> > > >
> > > > Thanks
> > > > Wei.
> > > > nvpublic
> > > >
> > > > -----Original Message-----
> > > > From: Takashi Iwai [mailto:tiwai(a)suse.de]
> > > > Sent: Thursday, March 04, 2010 5:47 PM
> > > > To: Wei Ni
> > > > Cc: 'Pavel Hofman'; 'alsa-devel'; 'linux-kernel'; 'akpm'
> > > > Subject: Re: [alsa-devel] [PATCH]Support MCP89 and GT21x hdmi audio
> > > >
> > > > At Thu, 4 Mar 2010 10:21:39 +0800,
> > > > Wei Ni wrote:
> > > > >
> > > > > Hi, Takashi
> > > > > 1. Yes, it can works for all Nvidia controller.
> > > >
> > > > OK.
> > > >
> > > > > 2. The hda_eld.o doesn't export any symbols.
> > > > > I tried to put hda_eld.o to snd-had-codec-*, and remove had_eldo.o
> > > > > from snd-had-codec-intelhdmi-objs, but it will build error. It need
> > > > > to modify hda_eld.c to export symbols, it will add many changes.
> > > >
> > > > Yes, this is unavoidable. Please add EXPORT_SYMBOL()'s
> > > > appropriately.
> > > >
> > > > We can reduce them again once after all HDMI stuff is merged into
> > > > one.
> > > >
> > > >
> > > > thanks,
> > > >
> > > > Takashi
> > > >
> > >
> >
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: VDR User on
I think this may be relevant to this subject, if not then my apologies.

I've just installed a GT220 card and was able to get audio-over-hdmi
working by compiling the snapshot drivers from 20100307 which contain
Wei's new code. I further had to patch the driver to recognize my
card with:

--- alsa-driver-orig/alsa-kernel/pci/hda/patch_nvhdmi.c 2010-03-06
18:00:12.000000000 -0800
+++ alsa-driver/alsa-kernel/pci/hda/patch_nvhdmi.c 2010-03-06
18:02:00.000000000 -0800
@@ -1335,6 +1335,8 @@ static struct hda_codec_preset snd_hda_p
.patch = patch_nvhdmi_8ch_89 },
{ .id = 0x10de000b, .name = "GT21x HDMI",
.patch = patch_nvhdmi_8ch_89 },
+ { .id = 0x10de000a, .name = "GT220 HDMI",
+ .patch = patch_nvhdmi_8ch_89 },
{ .id = 0x10de000d, .name = "GT240 HDMI",
.patch = patch_nvhdmi_8ch_89 },
{} /* terminator */
@@ -1347,6 +1349,7 @@ MODULE_ALIAS("snd-hda-codec-id:10de0006"
MODULE_ALIAS("snd-hda-codec-id:10de0007");
MODULE_ALIAS("snd-hda-codec-id:10de0067");
MODULE_ALIAS("snd-hda-codec-id:10de8001");
+MODULE_ALIAS("snd-hda-codec-id:10de000a");
MODULE_ALIAS("snd-hda-codec-id:10de000c");
MODULE_ALIAS("snd-hda-codec-id:10de000b");
MODULE_ALIAS("snd-hda-codec-id:10de000d");

This seems to work fine when running VDR but if I do anything else
like upgrade packages, compile something, or maybe create a bz2, then
I start to see _a lot_ of the following in my xine log:

pcm_hw.c: snd_pcm_hw_delay() SNDRV_PCM_IOCTL_DELAY failed.

With the old code this didn't happen. However, my setup was an 8400gs
using SPDIF OUT from my mainboard to SPDIF IN on the card. Then using
a dvi->hdmi cable into the tv.

Again, I apologize if I'm posting this in the wrong place.

Best regards.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Wu Fengguang on
CC Jaroslav, maybe he has some idea on

pcm_hw.c: snd_pcm_hw_delay() SNDRV_PCM_IOCTL_DELAY failed.

On Mon, Mar 08, 2010 at 12:35:37PM +0800, Wei Ni wrote:
> Hi,
> Because I don't have GT220 card on hand, I didn't test it yet.
> So I didn't add this card to the patch file. I think you could add it after
> you test it.
>
> About the warning messages, I don't know why.
> May be some others can answer.
>
> Thanks
> Wei.
> nvpublic
>
> -----Original Message-----
> From: VDR User [mailto:user.vdr(a)gmail.com]
> Sent: Monday, March 08, 2010 3:22 AM
> To: Wei Ni
> Cc: Takashi Iwai; akpm; alsa-devel; Wu Fengguang; linux-kernel; Pavel Hofman
> Subject: Re: [alsa-devel] [PATCH]Support MCP89 and GT21x hdmi audio
>
> I think this may be relevant to this subject, if not then my apologies.
>
> I've just installed a GT220 card and was able to get audio-over-hdmi
> working by compiling the snapshot drivers from 20100307 which contain
> Wei's new code. I further had to patch the driver to recognize my
> card with:
>
> --- alsa-driver-orig/alsa-kernel/pci/hda/patch_nvhdmi.c 2010-03-06
> 18:00:12.000000000 -0800
> +++ alsa-driver/alsa-kernel/pci/hda/patch_nvhdmi.c 2010-03-06
> 18:02:00.000000000 -0800
> @@ -1335,6 +1335,8 @@ static struct hda_codec_preset snd_hda_p
> .patch = patch_nvhdmi_8ch_89 },
> { .id = 0x10de000b, .name = "GT21x HDMI",
> .patch = patch_nvhdmi_8ch_89 },
> + { .id = 0x10de000a, .name = "GT220 HDMI",
> + .patch = patch_nvhdmi_8ch_89 },
> { .id = 0x10de000d, .name = "GT240 HDMI",
> .patch = patch_nvhdmi_8ch_89 },
> {} /* terminator */
> @@ -1347,6 +1349,7 @@ MODULE_ALIAS("snd-hda-codec-id:10de0006"
> MODULE_ALIAS("snd-hda-codec-id:10de0007");
> MODULE_ALIAS("snd-hda-codec-id:10de0067");
> MODULE_ALIAS("snd-hda-codec-id:10de8001");
> +MODULE_ALIAS("snd-hda-codec-id:10de000a");
> MODULE_ALIAS("snd-hda-codec-id:10de000c");
> MODULE_ALIAS("snd-hda-codec-id:10de000b");
> MODULE_ALIAS("snd-hda-codec-id:10de000d");
>
> This seems to work fine when running VDR but if I do anything else
> like upgrade packages, compile something, or maybe create a bz2, then
> I start to see _a lot_ of the following in my xine log:
>
> pcm_hw.c: snd_pcm_hw_delay() SNDRV_PCM_IOCTL_DELAY failed.
>
> With the old code this didn't happen. However, my setup was an 8400gs
> using SPDIF OUT from my mainboard to SPDIF IN on the card. Then using
> a dvi->hdmi cable into the tv.
>
> Again, I apologize if I'm posting this in the wrong place.
>
> Best regards.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/