Prev: [PATCH] x86,perf: Enable not tagged retired instruction counting
Next: [PATCH V2 1/2] cpuset: fix the problem that cpuset_mem_spread_node() returns an offline node - fix
From: Miao Xie on 15 Mar 2010 01:30
Changes from V1 to V2:
- remove unnecessary checking.

fix memory leak

Signed-off-by: Miao Xie <miaox(a)cn.fujitsu.com>
---
Against the following patch in mmotm-2010-03-11-13-13:
cpuset-alloc-nodemask_t-at-heap-not-stack.patch
---
kernel/cpuset.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/kernel/cpuset.c b/kernel/cpuset.c
index f36e577..02b4545 100644
--- a/kernel/cpuset.c
+++ b/kernel/cpuset.c
@@ -1401,7 +1401,7 @@ static void cpuset_attach(struct cgroup_subsys *ss, struct cgroup *cont,
NODEMASK_ALLOC(nodemask_t, to, GFP_KERNEL);

if (from == NULL || to == NULL)
- return;
+ goto alloc_fail;

if (cs == &top_cpuset) {
cpumask_copy(cpus_attach, cpu_possible_mask);
@@ -1432,6 +1432,7 @@ static void cpuset_attach(struct cgroup_subsys *ss, struct cgroup *cont,
mmput(mm);
}

+alloc_fail:
NODEMASK_FREE(from);
NODEMASK_FREE(to);
}
--
1.6.5.2


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH] x86,perf: Enable not tagged retired instruction counting
Next: [PATCH V2 1/2] cpuset: fix the problem that cpuset_mem_spread_node() returns an offline node - fix