Prev: [PATCH 3/3 ] SCSI: Remove the AER section in kconfig file
Next: TCP stream performance regression due to c377411f2494a931ff7facdbb3a6839b1266bcf6
From: Lai Jiangshan on 18 Jun 2010 04:20
If we use function graph filter(echo some_functions >> set_graph_function)
we are only interested in the graph of some_functions.

But if a interrupt occurs when these functions are being traced(or preparing),
the graphs of the handlers of this interrupt are also recorded.
These events that we aren't interested in are totally noisy.

This patch skip the noise when TRACE_GRAPH_FILTER_SKIP_INTR flag is on
(very very seldom noise is still left, It's OK for tracing, doesn't it?).

changed from v1:
Add a TRACE_GRAPH_FILTER_SKIP_INTR flag which is default off
to control it.

Signed-off-by: Lai Jiangshan <laijs(a)cn.fujitsu.com>
---
diff --git a/kernel/trace/trace_functions_graph.c b/kernel/trace/trace_functions_graph.c
index 79f4bac..d4fa4a4 100644
--- a/kernel/trace/trace_functions_graph.c
+++ b/kernel/trace/trace_functions_graph.c
@@ -12,6 +12,8 @@
#include <linux/slab.h>
#include <linux/fs.h>

+#include <asm/irq_regs.h>
+
#include "trace.h"
#include "trace_output.h"

@@ -41,6 +43,7 @@ struct fgraph_data {
#define TRACE_GRAPH_PRINT_PROC 0x8
#define TRACE_GRAPH_PRINT_DURATION 0x10
#define TRACE_GRAPH_PRINT_ABS_TIME 0x20
+#define TRACE_GRAPH_FILTER_SKIP_INTR 0x40

static struct tracer_opt trace_opts[] = {
/* Display overruns? (for self-debug purpose) */
@@ -55,6 +58,8 @@ static struct tracer_opt trace_opts[] = {
{ TRACER_OPT(funcgraph-duration, TRACE_GRAPH_PRINT_DURATION) },
/* Display absolute time of an entry */
{ TRACER_OPT(funcgraph-abstime, TRACE_GRAPH_PRINT_ABS_TIME) },
+ /* Skip the graph nested in interrupts when funcgraph filter enabled */
+ { TRACER_OPT(funcgraph-filter-skip-intr, TRACE_GRAPH_FILTER_SKIP_INTR) },
{ } /* Empty entry */
};

@@ -213,13 +218,22 @@ int trace_graph_entry(struct ftrace_graph_ent *trace)
int ret;
int cpu;
int pc;
+ int depth = trace->depth;
+ unsigned long long cntxt = (unsigned long)(void *)get_irq_regs();

if (!ftrace_trace_task(current))
return 0;

/* trace it when it is-nested-in or is a function enabled. */
- if (!(trace->depth || ftrace_graph_addr(trace->func)))
- return 0;
+ if (!ftrace_graph_addr(trace->func)) {
+ if (!depth)
+ return 0;
+ if ((tracer_flags.val & TRACE_GRAPH_FILTER_SKIP_INTR)
+ && (current->ret_stack[depth - 1].subtime != cntxt))
+ return 0;
+ }
+ /* We don't use subtime here, reuse it to save context. */
+ current->ret_stack[depth].subtime = cntxt;

local_irq_save(flags);
cpu = raw_smp_processor_id();

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH 3/3 ] SCSI: Remove the AER section in kconfig file
Next: TCP stream performance regression due to c377411f2494a931ff7facdbb3a6839b1266bcf6