Prev: [PATCH] SCSI: mvsas, fix potential NULL dereference
Next: firewire: core: no need to track irq flags in bm_work
From: Jiri Slaby on 22 Jun 2010 07:50
Stanse found that in ivtvfb_callback_cleanup there is an unneeded test
for itv being NULL. But itv is initialized as container_of with
non-zero offset, so it is never NULL (even if v4l2_dev is). This was
found because itv is dereferenced earlier than the test.

Signed-off-by: Jiri Slaby <jslaby(a)suse.cz>
Cc: Andy Walls <awalls(a)md.metrocast.net>
Cc: Mauro Carvalho Chehab <mchehab(a)infradead.org>
Cc: Tejun Heo <tj(a)kernel.org>
Cc: Ian Armstrong <ian(a)iarmst.demon.co.uk>
Cc: ivtv-devel(a)ivtvdriver.org
Cc: linux-media(a)vger.kernel.org
---
drivers/media/video/ivtv/ivtvfb.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/media/video/ivtv/ivtvfb.c b/drivers/media/video/ivtv/ivtvfb.c
index 9ff3425..5dc460e 100644
--- a/drivers/media/video/ivtv/ivtvfb.c
+++ b/drivers/media/video/ivtv/ivtvfb.c
@@ -1219,7 +1219,7 @@ static int ivtvfb_callback_cleanup(struct device *dev, void *p)
struct ivtv *itv = container_of(v4l2_dev, struct ivtv, v4l2_dev);
struct osd_info *oi = itv->osd_info;

- if (itv && (itv->v4l2_cap & V4L2_CAP_VIDEO_OUTPUT)) {
+ if (itv->v4l2_cap & V4L2_CAP_VIDEO_OUTPUT) {
if (unregister_framebuffer(&itv->osd_info->ivtvfb_info)) {
IVTVFB_WARN("Framebuffer %d is in use, cannot unload\n",
itv->instance);
--
1.7.1


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH] SCSI: mvsas, fix potential NULL dereference
Next: firewire: core: no need to track irq flags in bm_work