[PATCH] binfmt_elf: plug a memory leak situation on dump_seek()
in [Kernel]
|
Prev: Security: Add __init to register_security to disable load a security module on runtime
Next: [git pull] Please pull powerpc.git next branch
From: André Goddard Rosa on 26 Feb 2010 23:00 Signed-off-by: André Goddard Rosa <andre.goddard(a)gmail.com> --- fs/binfmt_elf.c | 10 +++++++--- 1 files changed, 7 insertions(+), 3 deletions(-) diff --git a/fs/binfmt_elf.c b/fs/binfmt_elf.c index fd5b2ea..13b0845 100644 --- a/fs/binfmt_elf.c +++ b/fs/binfmt_elf.c @@ -1096,6 +1096,8 @@ static int dump_write(struct file *file, const void *addr, int nr) static int dump_seek(struct file *file, loff_t off) { + int ret = 1; + if (file->f_op->llseek && file->f_op->llseek != no_llseek) { if (file->f_op->llseek(file, off, SEEK_CUR) < 0) return 0; @@ -1107,13 +1109,15 @@ static int dump_seek(struct file *file, loff_t off) unsigned long n = off; if (n > PAGE_SIZE) n = PAGE_SIZE; - if (!dump_write(file, buf, n)) - return 0; + if (!dump_write(file, buf, n)) { + ret = 0; + break; + } off -= n; } free_page((unsigned long)buf); } - return 1; + return ret; } /* -- 1.7.0.94.gf7311 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |