[PATCH] cgroup: do not use dprintf in cgroup_event_listener
in [Kernel]
|
Prev: KVM: SVM: Implement emulation of vm_cr msr
Next: Route kbd leds through the generic leds layer (3rd version)
From: Kirill A. Shutemov on 25 Feb 2010 05:30 glibc's dprintf(3) is buggy: http://sourceware.org/bugzilla/show_bug.cgi?id=11319 Let's not to use it in the example. Signed-off-by: Kirill A. Shutemov <kirill(a)shutemov.name> --- Documentation/cgroups/cgroup_event_listener.c | 11 +++++++++-- 1 files changed, 9 insertions(+), 2 deletions(-) diff --git a/Documentation/cgroups/cgroup_event_listener.c b/Documentation/cgroups/cgroup_event_listener.c index 8c2d7aa..8c2bfc4 100644 --- a/Documentation/cgroups/cgroup_event_listener.c +++ b/Documentation/cgroups/cgroup_event_listener.c @@ -23,6 +23,7 @@ int main(int argc, char **argv) int cfd = -1; int event_control = -1; char event_control_path[PATH_MAX]; + char line[LINE_MAX]; int ret; if (argc != 3) { @@ -39,7 +40,7 @@ int main(int argc, char **argv) ret = snprintf(event_control_path, PATH_MAX, "%s/cgroup.event_control", dirname(argv[1])); - if (ret > PATH_MAX) { + if (ret >= PATH_MAX) { fputs("Path to cgroup.event_control is too long\n", stderr); goto out; } @@ -57,7 +58,13 @@ int main(int argc, char **argv) goto out; } - ret = dprintf(event_control, "%d %d %s", efd, cfd, argv[2]); + ret = snprintf(line, LINE_MAX, "%d %d %s", efd, cfd, argv[2]); + if (ret >= LINE_MAX) { + fputs("Arguments string is too long\n", stderr); + goto out; + } + + ret = write(event_control, line, strlen(line) + 1); if (ret == -1) { perror("Cannot write to cgroup.event_control"); goto out; -- 1.6.6.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |