Prev: platform: Facilitate the creation of pseduo-platform busses
Next: linux-next: build failure after merge of the block tree
From: Patrick Pannuto on 4 Aug 2010 21:40
These are caused by checkpatch incorrectly parsing its
internal representation of a statement block for struct's
(or anything else that is a statement block encapsulated
in {}'s that also ends with a ';'). Fix this by properly
parsing a statement block.

An example:
diff --git a/dummy.c b/dummy.c
new file mode 100644
index 0000000..3a932a5
--- /dev/null
+++ b/dummy.c
@@ -0,0 +1,12 @@
+struct dummy_type dummy = {
+ .foo = "baz",
+};
+EXPORT_SYMBOL_GPL(dummy);
+
+static int dummy_func(void)
+{
+ return -EDUMMYCODE;
+}
+EXPORT_SYMBOL_GPL(dummy_func);

WARNING: EXPORT_SYMBOL(foo); should immediately \
follow its function/variable
#19: FILE: dummy.c:4:
+EXPORT_SYMBOL_GPL(dummy);

The above warning is issued when it should not be.

Signed-off-by: Patrick Pannuto <ppannuto(a)codeaurora.org>
---
scripts/checkpatch.pl | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index bd88f11..6affee2 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -552,6 +552,9 @@ sub ctx_statement_block {
$type = ($level != 0)? '{' : '';

if ($level == 0) {
+ if (substr($blk, $off + 1, 1) eq ';') {
+ $off++;
+ }
last;
}
}
--
1.7.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: platform: Facilitate the creation of pseduo-platform busses
Next: linux-next: build failure after merge of the block tree