[PATCH] get_maintainer: Repair STDIN usage
in [Kernel]
|
Prev: get_maintainer: Repair STDIN usage
Next: BUG: Is it a bug in Linux time() function or Linux OS calls?
From: Wolfram Sang on 10 Mar 2010 03:30 Commit 22dd5b0cba50a197aaa3bd2790a29ee2e8e4e372 (fix perlcritic warnings) broke the ability to handle STDIN because the three argument version of open() cannot handle standard IO-streams (which is mentioned in PerlBestPractices, too). Signed-off-by: Wolfram Sang <w.sang(a)pengutronix.de> Cc: Stephen Hemminger <shemminger(a)vyatta.com> Cc: Joe Perches <joe(a)perches.com> --- Like checkpatch, the hints from perlcritic should be double-checked ;) scripts/get_maintainer.pl | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl index f76f3d1..6f97a13 100755 --- a/scripts/get_maintainer.pl +++ b/scripts/get_maintainer.pl @@ -284,7 +284,7 @@ foreach my $file (@ARGV) { my $file_cnt = @files; my $lastfile; - open(my $patch, '<', $file) + open(my $patch, "< $file") or die "$P: Can't open $file: $!\n"; while (<$patch>) { my $patch_line = $_; -- 1.7.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |