Prev: [PATCH -next] staging: fix wlan-ng printk format warning
Next: Add this to tip (was: Re: [RFC patch] introduce sys_membarrier(): process-wide memory barrier (v9))
From: Oleg Nesterov on 25 Feb 2010 13:20
(on top of kmod-replace-call_usermodehelper_pipe-with-use-of-umh-init-function-and-resolve-limit.patch)

David, all.

I was going to do some minor fixes in kmod.c, but looking at this
code I am really puzzled by subprocess_info->cred complications.
I know absoulutely nothing about creds/keys, but at first glance
this all looks completely unnecessary?

IOW, please review these 2 simple patches. And sorry, I have no
idea how to really test these changes.


In case you are not aware of recent call_usermodehelper() changes
in -mm: struct subprocess_info has the new members,

int (*init)(struct subprocess_info *info);
void (*cleanup)(struct subprocess_info *info);
void *data;

info->init() is called by ____call_usermodehelper() right before kernel_execve(),
info->cleanup() is called by call_usermodehelper_freeinfo().
info->data is obvious.

And we have the new helper, call_usermodehelper_setfns(init, cleanup, data)
which merely initializes these members.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH -next] staging: fix wlan-ng printk format warning
Next: Add this to tip (was: Re: [RFC patch] introduce sys_membarrier(): process-wide memory barrier (v9))