Prev: [PATCH -mm 05/17] sysctl extern cleanup - mm
Next: [PATCH -mm 11/17] sysctl extern cleanup - module
From: Dave Young on 21 Feb 2010 09:30
Extern declarations in sysctl.c should be move to their own head file,
and then include them in relavant .c files.

Move core_uses_pid/core_pattern/core_pipe_limit extern declarations
to linux/binfmts.h
suid_dumpable is declared in binfmts.h already.

Signed-off-by: Dave Young <hidave.darkstar(a)gmail.com>
---
include/linux/binfmts.h | 5 +++++
kernel/sysctl.c | 5 +----
2 files changed, 6 insertions(+), 4 deletions(-)

--- linux-2.6.32.orig/kernel/sysctl.c 2010-02-21 09:43:05.206481916 +0800
+++ linux-2.6.32/kernel/sysctl.c 2010-02-21 09:44:39.479806692 +0800
@@ -55,6 +55,7 @@
#include <linux/perf_event.h>
#include <linux/rcustring.h>
#include <linux/signal.h>
+#include <linux/binfmts.h>

#include <asm/uaccess.h>
#include <asm/processor.h>
@@ -70,10 +71,6 @@

/* External variables not in a header file. */
extern int max_threads;
-extern int core_uses_pid;
-extern int suid_dumpable;
-extern char *core_pattern;
-extern unsigned int core_pipe_limit;
extern int pid_max;
extern int min_free_kbytes;
extern int pid_max_min, pid_max_max;
--- linux-2.6.32.orig/include/linux/binfmts.h 2010-02-21 09:35:58.627357104 +0800
+++ linux-2.6.32/include/linux/binfmts.h 2010-02-21 09:45:32.279801314 +0800
@@ -20,6 +20,11 @@ struct pt_regs;
#ifdef __KERNEL__
#include <linux/list.h>

+/* for sysctl */
+extern int core_uses_pid;
+extern char *core_pattern;
+extern unsigned int core_pipe_limit;
+
#define CORENAME_MAX_SIZE 128

/*
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH -mm 05/17] sysctl extern cleanup - mm
Next: [PATCH -mm 11/17] sysctl extern cleanup - module