[PATCH] perf: Also export the weak version of perf_arch_fetch_caller_regs
in [Kernel]
|
Prev: [PATCH 1/3] memcg: oom wakeup filter
Next: perf: Also export the weak version of perf_arch_fetch_caller_regs
From: Frederic Weisbecker on 12 Mar 2010 01:00 On Fri, Mar 12, 2010 at 03:00:03PM +1100, Stephen Rothwell wrote: > Hi all, > > After merging the tip tree, today's linux-next build (powerpc > ppc64_defconfig) failed like this: > > ERROR: ".perf_arch_fetch_caller_regs" [fs/xfs/xfs.ko] undefined! > ERROR: ".perf_arch_fetch_caller_regs" [arch/powerpc/platforms/cell/spufs/spufs.ko] undefined! > > Caused by commit 5331d7b84613b8325362dde53dc2bff2fb87d351 ("perf: > Introduce new perf_fetch_caller_regs() for hot regs snapshot") from the > tip tree. Presumably commit 639fe4b12f92b54c9c3b38c82cdafaa38cfd3e63 > ("perf: export perf_trace_regs and perf_arch_fetch_caller_regs") should > have exported the weak version as well as the x86 one. > > I have used the version of the tip tree from next-20100311 for today. Does that fixes the issue? Sorry I can not test for now... Thanks! --- From 0b21e01edb23b4725d20a9e5fddb6df7fedd16e1 Mon Sep 17 00:00:00 2001 From: Frederic Weisbecker <fweisbec(a)gmail.com> Date: Fri, 12 Mar 2010 06:23:22 +0100 Subject: [PATCH] perf: Also export the weak version of perf_arch_fetch_caller_regs perf_arch_fetch_caller_regs() is exported in x86 but not for other archs that use the weak version. Export it only once from the generic code, it will apply to either weak/overriden version. Signed-off-by: Frederic Weisbecker <fweisbec(a)gmail.com> --- arch/x86/kernel/cpu/perf_event.c | 1 - kernel/perf_event.c | 1 + 2 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/x86/kernel/cpu/perf_event.c b/arch/x86/kernel/cpu/perf_event.c index a6d92c3..a3aff76 100644 --- a/arch/x86/kernel/cpu/perf_event.c +++ b/arch/x86/kernel/cpu/perf_event.c @@ -1691,4 +1691,3 @@ void perf_arch_fetch_caller_regs(struct pt_regs *regs, unsigned long ip, int ski regs->cs = __KERNEL_CS; local_save_flags(regs->flags); } -EXPORT_SYMBOL_GPL(perf_arch_fetch_caller_regs); diff --git a/kernel/perf_event.c b/kernel/perf_event.c index 8bf6127..7aea58d 100644 --- a/kernel/perf_event.c +++ b/kernel/perf_event.c @@ -2794,6 +2794,7 @@ __weak void perf_arch_fetch_caller_regs(struct pt_regs *regs, unsigned long ip, int skip) { } +EXPORT_SYMBOL_GPL(perf_arch_fetch_caller_regs); /* * Output -- 1.6.2.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |