Prev: cfq-iosched: Keep track of average think time for the sync-noidle workload.
Next: [PATCH] ALSA: Add initial support for Thinkpad T410s HDA codec.
From: Frederic Weisbecker on 14 Apr 2010 18:00
From: Thomas Gleixner <tglx(a)linutronix.de>

Checking if a tracing field is an array with a dynamic length
requires to check the field type and seek the "__data_loc" string
that prepends the actual type, as can be found in a trace event
format file:

field:__data_loc char[] name; offset:16; size:4; signed:1;

But we actually use strcmp() to check if the field type fully
matches "__data_loc", which may fail as we trip over the rest of the
type.

To fix this, use strncmp to only check if it starts with "__data_loc".

Signed-off-by: Thomas Gleixner <tglx(a)linutronix.de>
Cc: Arnaldo Carvalho de Melo <acme(a)redhat.com>
Cc: Peter Zijlstra <a.p.zijlstra(a)chello.nl>
Cc: Paul Mackerras <paulus(a)samba.org>
Cc: Ingo Molnar <mingo(a)elte.hu>
Cc: Tom Zanussi <tzanussi(a)gmail.com>
Cc: Steven Rostedt <rostedt(a)goodmis.org>
Signed-off-by: Frederic Weisbecker <fweisbec(a)gmail.com>
---
tools/perf/util/trace-event-parse.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/tools/perf/util/trace-event-parse.c b/tools/perf/util/trace-event-parse.c
index 17d6d66..d6ef414 100644
--- a/tools/perf/util/trace-event-parse.c
+++ b/tools/perf/util/trace-event-parse.c
@@ -761,7 +761,7 @@ static int field_is_string(struct format_field *field)

static int field_is_dynamic(struct format_field *field)
{
- if (!strcmp(field->type, "__data_loc"))
+ if (!strncmp(field->type, "__data_loc", 10))
return 1;

return 0;
--
1.6.2.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: cfq-iosched: Keep track of average think time for the sync-noidle workload.
Next: [PATCH] ALSA: Add initial support for Thinkpad T410s HDA codec.