[PATCH] [resend] unusual_devs.h: Fix capacity for SL11R-IDE 2.6c
in [Kernel]
|
Prev: [PATCH] security: fix error return path in ima_inode_alloc
Next: Regulators: virtual - use sysfs attribute groups
From: Ondrej Zary on 24 Feb 2010 05:50 SL11R-IDE 2.6c (at least) reports wrong capacity (one sector more). Reading that last sector causes the device not to work anymore (and looks like HAL or something does that automatically after plugging in): sd 5:0:0:0: [sdc] Device not ready sd 5:0:0:0: [sdc] Result: hostbyte=0x00 driverbyte=0x08 sd 5:0:0:0: [sdc] Sense Key : 0x2 [current] sd 5:0:0:0: [sdc] ASC=0x0 ASCQ=0x0 sd 5:0:0:0: [sdc] CDB: cdb[0]=0x28: 28 00 04 a8 b5 70 00 00 01 00 Add unusual_devs entry to fix the capacity. Signed-off-by: Ondrej Zary <linux(a)rainbow-software.org> --- linux-2.6.32-orig/drivers/usb/storage/unusual_devs.h 2009-12-03 04:51:21.000000000 +0100 +++ linux-2.6.32/drivers/usb/storage/unusual_devs.h 2010-02-21 20:23:12.000000000 +0100 @@ -374,6 +374,12 @@ UNUSUAL_DEV( 0x04ce, 0x0002, 0x0074, 0x US_SC_DEVICE, US_PR_DEVICE, NULL, US_FL_FIX_INQUIRY), +UNUSUAL_DEV( 0x04ce, 0x0002, 0x026c, 0x026c, + "ScanLogic", + "SL11R-IDE", + US_SC_DEVICE, US_PR_DEVICE, NULL, + US_FL_FIX_CAPACITY), + /* Reported by Kriston Fincher <kriston(a)airmail.net> * Patch submitted by Sean Millichamp <sean(a)bruenor.org> * This is to support the Panasonic PalmCam PV-SD4090 -- Ondrej Zary -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Matthew Dharm on 24 Feb 2010 14:40 On Wed, Feb 24, 2010 at 11:41:08AM +0100, Ondrej Zary wrote: > SL11R-IDE 2.6c (at least) reports wrong capacity (one sector more). > Reading that last sector causes the device not to work anymore (and looks > like HAL or something does that automatically after plugging in): > sd 5:0:0:0: [sdc] Device not ready > sd 5:0:0:0: [sdc] Result: hostbyte=0x00 driverbyte=0x08 > sd 5:0:0:0: [sdc] Sense Key : 0x2 [current] > sd 5:0:0:0: [sdc] ASC=0x0 ASCQ=0x0 > sd 5:0:0:0: [sdc] CDB: cdb[0]=0x28: 28 00 04 a8 b5 70 00 00 01 00 > > Add unusual_devs entry to fix the capacity. Why not just adjust the version range of the entry above where you added a new one? If you just expand the upper version of the previous entry, it should cover both devices. Matt -- Matthew Dharm Home: mdharm-usb(a)one-eyed-alien.net Maintainer, Linux USB Mass Storage Driver Oh BAY-bee. -- Dust Puppy to Greg User Friendly, 12/13/1997
From: Ondrej Zary on 24 Feb 2010 16:30 On Wednesday 24 February 2010 20:29:59 Matthew Dharm wrote: > On Wed, Feb 24, 2010 at 11:41:08AM +0100, Ondrej Zary wrote: > > SL11R-IDE 2.6c (at least) reports wrong capacity (one sector more). > > Reading that last sector causes the device not to work anymore (and looks > > like HAL or something does that automatically after plugging in): > > sd 5:0:0:0: [sdc] Device not ready > > sd 5:0:0:0: [sdc] Result: hostbyte=0x00 driverbyte=0x08 > > sd 5:0:0:0: [sdc] Sense Key : 0x2 [current] > > sd 5:0:0:0: [sdc] ASC=0x0 ASCQ=0x0 > > sd 5:0:0:0: [sdc] CDB: cdb[0]=0x28: 28 00 04 a8 b5 70 00 00 01 00 > > > > Add unusual_devs entry to fix the capacity. > > Why not just adjust the version range of the entry above where you added a > new one? Because that entry fixes IDENTIFY. My version does not seem to have any problems with IDENTIFY. Or maybe it has but kernel can now handle it automatically: usb 1-1: new full speed USB device using uhci_hcd and address 4 usb 1-1: configuration #1 chosen from 1 choice scsi5 : SCSI emulation for USB Mass Storage devices usb-storage: device found at 4 usb-storage: waiting for device to settle before scanning scsi scan: INQUIRY result too short (5), using 36 scsi 5:0:0:0: Direct-Access WDC WD40 0BB-00AUA1 18.2 PQ: 0 ANSI: 1 sd 5:0:0:0: Attached scsi generic sg3 type 0 > If you just expand the upper version of the previous entry, it should cover > both devices. > > Matt -- Ondrej Zary -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Matthew Dharm on 24 Feb 2010 17:50 Phil D. -- I recommend circling around with pwaechtler(a)loewe-komp.de to see if we can't condense these into a single entry. Matt On Wed, Feb 24, 2010 at 10:22:18PM +0100, Ondrej Zary wrote: > On Wednesday 24 February 2010 20:29:59 Matthew Dharm wrote: > > On Wed, Feb 24, 2010 at 11:41:08AM +0100, Ondrej Zary wrote: > > > SL11R-IDE 2.6c (at least) reports wrong capacity (one sector more). > > > Reading that last sector causes the device not to work anymore (and looks > > > like HAL or something does that automatically after plugging in): > > > sd 5:0:0:0: [sdc] Device not ready > > > sd 5:0:0:0: [sdc] Result: hostbyte=0x00 driverbyte=0x08 > > > sd 5:0:0:0: [sdc] Sense Key : 0x2 [current] > > > sd 5:0:0:0: [sdc] ASC=0x0 ASCQ=0x0 > > > sd 5:0:0:0: [sdc] CDB: cdb[0]=0x28: 28 00 04 a8 b5 70 00 00 01 00 > > > > > > Add unusual_devs entry to fix the capacity. > > > > Why not just adjust the version range of the entry above where you added a > > new one? > > Because that entry fixes IDENTIFY. My version does not seem to have any > problems with IDENTIFY. Or maybe it has but kernel can now handle it > automatically: > usb 1-1: new full speed USB device using uhci_hcd and address 4 > usb 1-1: configuration #1 chosen from 1 choice > scsi5 : SCSI emulation for USB Mass Storage devices > usb-storage: device found at 4 > usb-storage: waiting for device to settle before scanning > scsi scan: INQUIRY result too short (5), using 36 > scsi 5:0:0:0: Direct-Access WDC WD40 0BB-00AUA1 18.2 PQ: 0 ANSI: 1 > sd 5:0:0:0: Attached scsi generic sg3 type 0 > > > > If you just expand the upper version of the previous entry, it should cover > > both devices. > > > > Matt > > > > -- > Ondrej Zary > _______________________________________________ > Usb-storage mailing list > Usb-storage(a)lists.one-eyed-alien.net > https://lists.one-eyed-alien.net/mailman/listinfo/usb-storage -- Matthew Dharm Home: mdharm-usb(a)one-eyed-alien.net Maintainer, Linux USB Mass Storage Driver E: You run this ship with Windows?! YOU IDIOT! L: Give me a break, it came bundled with the computer! -- ESR and Lan Solaris User Friendly, 12/8/1998
From: Matthew Dharm on 27 Feb 2010 15:40
On Sat, Feb 27, 2010 at 08:11:53PM +0100, Phil Dibowitz wrote: > On 02/24/2010 11:47 PM, Matthew Dharm wrote: > > Phil D. -- > > > > I recommend circling around with pwaechtler(a)loewe-komp.de to see if we > > can't condense these into a single entry. > > I'm with Ondrej here, I suspect that entry is completely unneeded now. We've > gotten pretty good at handling bad INQUIRYs. > > So unless you object, I'm going to allow Ondrej's patch, and then I'll fire > up a patch to remove the other version and fire it off to Peter W. to see if > his device works without it. Seems like a reasonable plan. Matt -- Matthew Dharm Home: mdharm-usb(a)one-eyed-alien.net Maintainer, Linux USB Mass Storage Driver S: Another stupid question? G: There's no such thing as a stupid question, only stupid people. -- Stef and Greg User Friendly, 7/15/1998 |