[PATCH] rtc-coh901331: Fix braces in resume code.
in [Kernel]
|
Prev: [Bug 15426] New: Running many copies of bonnie++ on different filesystems seems to deadlock in sync
Next: verifying whitespace patches don't change anything was Re: [PATCH] Staging:rtl8192e: fix comments
From: James Hogan on 3 Mar 2010 07:00 The else part of the if statement is indented but does not have braces around it. It clearly should since it uses clk_enable and clk_disable which are supposed to balance. Signed-off-by: James Hogan <james(a)albanarts.com> --- drivers/rtc/rtc-coh901331.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-coh901331.c b/drivers/rtc/rtc-coh901331.c index 03ea530..44c4399 100644 --- a/drivers/rtc/rtc-coh901331.c +++ b/drivers/rtc/rtc-coh901331.c @@ -271,12 +271,13 @@ static int coh901331_resume(struct platform_device *pdev) { struct coh901331_port *rtap = dev_get_drvdata(&pdev->dev); - if (device_may_wakeup(&pdev->dev)) + if (device_may_wakeup(&pdev->dev)) { disable_irq_wake(rtap->irq); - else + } else { clk_enable(rtap->clk); writel(rtap->irqmaskstore, rtap->virtbase + COH901331_IRQ_MASK); clk_disable(rtap->clk); + } return 0; } #else -- 1.5.5.6 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Alessandro Zummo on 3 Mar 2010 10:20
On Wed, 3 Mar 2010 11:55:15 +0000 James Hogan <james(a)albanarts.com> wrote: > The else part of the if statement is indented but does not have braces > around it. It clearly should since it uses clk_enable and clk_disable > which are supposed to balance. > > Signed-off-by: James Hogan <james(a)albanarts.com> Acked-by: Alessandro Zummo <a.zummo(a)towertech.it> -- Best regards, Alessandro Zummo, Tower Technologies - Torino, Italy http://www.towertech.it -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |