[PATCH v2 0/6] hid: new driver for PicoLCD device
in [Kernel]
|
Prev: [PATCH] Netfilter: Fix integer overflow in net/ipv6/netfilter/ip6_tables.c
Next: staging: winbond: reg.c Coding style fixes.
From: Bruno Prémont on 20 Mar 2010 12:20 This series adds support for PicoLCD USB HID device adding support for the various features in different patches so each patch concentrates on a device class. I implemented the patches so input support is required (this should make it easy to later on add support for other PicoLCD device that don't have the same feature set but share compatible HID reports. This causes presence of a few #ifdef blocks to include support for the different feature sets when their matching device class has been selected. Though to minimize the amount of such #ifs I put all code for a single class together and defined a few stubs in the #else part so global device initialization is not filled with #ifs. I'm not sure which of the following approaches is better (I took the first one): - Check for built-in or build-as-module class support with #if defined(): #if defined(CONFIG_..CLASS) || defined(CONFIG_..CLASS_MODULE) - Add extra CONFIG_PICOLCD_$CLASS to Kconfig and let Kconfig get things correctly set having just simple #ifdef CONFIG_PICOLCD_$CLASS in the code. The series depends on my previous patch adding HID suspend support (I've not yet looked at improving it). The patch adding support for backlight class depends on backlight state as of 2.6.34-rc2. All the rest should apply against 2.6.33 (unless I did oversee some detail). Bruno -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |