Prev: (none)
Next: [PATCH] lib/hexdump.c: Reduce stack variable size and cleanups
From: Jean Delvare on 3 Apr 2010 03:30
Hi Steven,

On Mon, 15 Mar 2010 13:52:17 +0100, Jean Delvare wrote:
> Hi Steven,
>
> On Sat, 13 Mar 2010 20:00:35 -0800, Steven King wrote:
> > Driver for the TI TMP102.
> >
> > Signed-off-by: Steven King <sfking(a)fdwdc.com>
> > ---
> >
> > The TI TMP102 is similar to the lm75. It differs from the lm75 by having a 16
> > bit conf register and the temp registers have a minimum resolution of 12bits;
> > the extended conf register can select 13 bit resolution (which this driver
> > does) and also change the update rate (which this driver currently doesn't
> > use).
> >
> > V2: removed broken and unneeded detection routine,
> > made temperature conversion use base 1000 instead of base 100.
> > (per Jean Delvare's feed back)
> > incorporated fixes for the loop and made dev_pm_ops const.
> > (per Andrew Morton's patch)
> >
> > Documentation/hwmon/tmp102 | 27 ++++
> > drivers/hwmon/Kconfig | 10 ++
> > drivers/hwmon/Makefile | 1 +
> > drivers/hwmon/tmp102.c | 296 ++++++++++++++++++++++++++++++++++++++++++++
> > 4 files changed, 334 insertions(+), 0 deletions(-)
>
> Here's my review. Feel free to pick whatever you like in it and ignore
> the rest. Then submit a final version for upstream integration.

Any update? Would be great to not lose all the work that both you and
me put in this driver so far.

--
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: (none)
Next: [PATCH] lib/hexdump.c: Reduce stack variable size and cleanups