Prev: Cosmetic:Partially remove deprecated __initcall() and change to
Next: [tip:x86/urgent] x86, amd: Restrict usage of c1e_idle()
From: Yinghai Lu on 19 Mar 2010 19:50
From: Ian Campbell <ian.campbell(a)citrix.com>

This avoids an infinite loop in free_early_partial().

Add a warning to free_early_partial to catch future problems.

-v3: according to hpa, don't bother caller.
-v4: start == end is ok?

Signed-off-by: Ian Campbell <ian.campbell(a)citrix.com>
Signed-off-by: Yinghai Lu <yinghai(a)kernel.org>
Cc: Peter Zijlstra <peterz(a)infradead.org>
Cc: Ingo Molnar <mingo(a)elte.hu>
---
kernel/early_res.c | 11 +++++++++++
1 file changed, 11 insertions(+)

Index: linux-2.6/kernel/early_res.c
===================================================================
--- linux-2.6.orig/kernel/early_res.c
+++ linux-2.6/kernel/early_res.c
@@ -333,6 +333,17 @@ void __init free_early_partial(u64 start
struct early_res *r;
int i;

+ if (start == end)
+ return;
+
+ if (start > end) {
+ WARN_ONCE(1,
+ "free_early_partial got wrong start/end %#llx/%#llx\n",
+ start, end);
+
+ return;
+ }
+
try_next:
i = find_overlapped_early(start, end);
if (i >= max_early_res)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: Cosmetic:Partially remove deprecated __initcall() and change to
Next: [tip:x86/urgent] x86, amd: Restrict usage of c1e_idle()