[PATCH] x86/PCI: never allocate PCI MMIO resources below BIOS_END
in [Kernel]
|
Prev: Union mounts - everything but the xattrs
Next: patch input-wacom-switch-mode-upon-system-resume.patch added to 2.6.33-stable tree
From: Bjorn Helgaas on 23 Apr 2010 19:10 On Wednesday 21 April 2010 01:31:20 pm Andy Isaacson wrote: > On Tue, Apr 20, 2010 at 10:33:50PM -0700, Yinghai wrote: > > Update e820 at first, and later put them resource tree. > > Reserved that early, will not be allocated to unassigned PCI BAR > > > > v3: remove probe_roms() that is not needed, because whole range is reserved > > already > > Test booted this patch series on the problematic t3400, seems to work > fine. dmesg attached to bug 15744. Thanks for testing (again). I'm not confident that this series is going to be successful, so I started looking for other approaches. I can't reproduce the exact problem you're seeing, but in my kludged-up attempt, the patch below is enough to keep us from assigning the space below 1MB to a device. Would you guys (Andy & Andy, what a coincidence :-)) mind giving it a try? This is intended to work on top of current upstream, with no other patches required. Bjorn commit 7fb707eb97fdf6dc4fa4b127f127f8d00223afc7 Author: Bjorn Helgaas <bjorn.helgaas(a)hp.com> Date: Fri Apr 23 15:22:10 2010 -0600 x86/PCI: never allocate PCI MMIO resources below BIOS_END When we move a PCI device or assign resources to a device not configured by the BIOS, we want to avoid the BIOS region below 1MB. Note that if the BIOS places devices below 1MB, we leave them there. See https://bugzilla.kernel.org/show_bug.cgi?id=15744 and https://bugzilla.kernel.org/show_bug.cgi?id=15841 Signed-off-by: Bjorn Helgaas <bjorn.helgaas(a)hp.com> diff --git a/arch/x86/pci/i386.c b/arch/x86/pci/i386.c index 46fd43f..97da2ba 100644 --- a/arch/x86/pci/i386.c +++ b/arch/x86/pci/i386.c @@ -72,6 +72,9 @@ pcibios_align_resource(void *data, const struct resource *res, return start; if (start & 0x300) start = (start + 0x3ff) & ~0x3ff; + } else if (res->flags & IORESOURCE_MEM) { + if (start < BIOS_END) + start = BIOS_END; } return start; } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |