Prev: [PATCH] time: Cleanup direct xtime usage in xen
Next: [PATCH] time: Cleanup warp_clock
From: John Stultz on 3 Mar 2010 22:20
Not critical, 2.6.35 material.

xtensa supports read_persisitent_clock(), so there is no reason for
the arch specific code to be setting xtime. Setting xtime will be done
by the generic timekeeping code.

Please let me know if this is some sort of a workaround for an issue
instead of just an oversight.

Cc: Thomas Gleixner <tglx(a)linutronix.de>
Cc: Andrew Morton <akpm(a)linux-foundation.org>
Cc: Chris Zankel <chris(a)zankel.net>
Signed-off-by: John Stultz <johnstul(a)us.ibm.com>
---
arch/xtensa/kernel/time.c | 5 -----
1 files changed, 0 insertions(+), 5 deletions(-)

diff --git a/arch/xtensa/kernel/time.c b/arch/xtensa/kernel/time.c
index 19f7df3..19df764 100644
--- a/arch/xtensa/kernel/time.c
+++ b/arch/xtensa/kernel/time.c
@@ -60,11 +60,6 @@ static struct irqaction timer_irqaction = {

void __init time_init(void)
{
- /* FIXME: xtime&wall_to_monotonic are set in timekeeping_init. */
- read_persistent_clock(&xtime);
- set_normalized_timespec(&wall_to_monotonic,
- -xtime.tv_sec, -xtime.tv_nsec);
-
#ifdef CONFIG_XTENSA_CALIBRATE_CCOUNT
printk("Calibrating CPU frequency ");
platform_calibrate_ccount();
--
1.6.0.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH] time: Cleanup direct xtime usage in xen
Next: [PATCH] time: Cleanup warp_clock