Prev: para virt interface of perf to support kvm guest os statistics collection in guest os
Next: Fix a race in pid generation that causes pids to be reused immediately.
From: Geert Uytterhoeven on 9 Jun 2010 05:40
proc_bus_zorro_read() didn't take into account the current file position,
hence it always read from the start of the ConfigDev.

Signed-off-by: Geert Uytterhoeven <geert(a)linux-m68k.org>

diff --git a/drivers/zorro/proc.c b/drivers/zorro/proc.c
index aaf8abb..108096f 100644
--- a/drivers/zorro/proc.c
+++ b/drivers/zorro/proc.c
@@ -73,7 +73,7 @@ proc_bus_zorro_read(struct file *file, char __user *buf, size_t nbytes, loff_t *
cd.cd_BoardAddr = (void *)zorro_resource_start(z);
cd.cd_BoardSize = zorro_resource_len(z);

- if (copy_to_user(buf, &cd, nbytes))
+ if (copy_to_user(buf, (void *)&cd + pos, nbytes))
return -EFAULT;
*ppos += nbytes;

--
1.7.0.4

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert(a)linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: para virt interface of perf to support kvm guest os statistics collection in guest os
Next: Fix a race in pid generation that causes pids to be reused immediately.