[PATCHv3 1/2] usb: gadget: storage: strict coversion of 'ro' parameter
in [Kernel]
|
Prev: [PATCHv3 2/2] usb: gadget: storage: optional SCSI WRITE FUA bit
Next: tpc-srv/tcp: nfsd: got error -104 when sending 116 bytes - shutting down socket
From: Andy Shevchenko on 15 Jul 2010 05:10 Bring a strict way to get the 'ro' parameter from the user. The idea was discussed in LKML [1]. [1] http://lkml.org/lkml/2010/7/13/143 Signed-off-by: Andy Shevchenko <ext-andriy.shevchenko(a)nokia.com> Cc: Alan Stern <stern(a)rowland.harvard.edu> Cc: David Brownell <dbrownell(a)users.sourceforge.net> Cc: Greg Kroah-Hartman <gregkh(a)suse.de> Cc: linux-usb(a)vger.kernel.org --- drivers/usb/gadget/storage_common.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/usb/gadget/storage_common.c b/drivers/usb/gadget/storage_common.c index 04c462f..7123929 100644 --- a/drivers/usb/gadget/storage_common.c +++ b/drivers/usb/gadget/storage_common.c @@ -723,9 +723,9 @@ static ssize_t fsg_store_ro(struct device *dev, struct device_attribute *attr, ssize_t rc = count; struct fsg_lun *curlun = fsg_lun_from_dev(dev); struct rw_semaphore *filesem = dev_get_drvdata(dev); - int i; + unsigned long ro; - if (sscanf(buf, "%d", &i) != 1) + if (strict_strtoul(buf, 2, &ro)) return -EINVAL; /* Allow the write-enable status to change only while the backing file @@ -735,8 +735,8 @@ static ssize_t fsg_store_ro(struct device *dev, struct device_attribute *attr, LDBG(curlun, "read-only status change prevented\n"); rc = -EBUSY; } else { - curlun->ro = !!i; - curlun->initially_ro = !!i; + curlun->ro = ro; + curlun->initially_ro = ro; LDBG(curlun, "read-only status set to %d\n", curlun->ro); } up_read(filesem); -- 1.6.3.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |