Prev: [PATCHv5 12/15] writeback: optimize periodic bdi thread wakeups
Next: [PATCHv5 06/15] writeback: simplify bdi code a little
From: Artem Bityutskiy on 25 Jul 2010 04:40
From: Artem Bityutskiy <Artem.Bityutskiy(a)nokia.com>

Add 2 new trace points to the periodic write-back wake up case, just like we do
in the 'bdi_queue_work()' function. Namely, introduce:

1. trace_writeback_wake_thread(bdi)
2. trace_writeback_wake_forker_thread(bdi)

The first event is triggered every time we wake up a bdi thread to start
periodic background write-out. The second event is triggered only when the bdi
thread does not exist and should be created by the forker thread.

This patch was suggested by Dave Chinner and Christoph Hellwig.

Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy(a)nokia.com>
---
include/trace/events/writeback.h | 2 ++
mm/backing-dev.c | 2 ++
2 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/include/trace/events/writeback.h b/include/trace/events/writeback.h
index 84ab72d..f345f66 100644
--- a/include/trace/events/writeback.h
+++ b/include/trace/events/writeback.h
@@ -81,6 +81,8 @@ DEFINE_EVENT(writeback_class, name, \
TP_ARGS(bdi))

DEFINE_WRITEBACK_EVENT(writeback_nowork);
+DEFINE_WRITEBACK_EVENT(writeback_wake_thread);
+DEFINE_WRITEBACK_EVENT(writeback_wake_forker_thread);
DEFINE_WRITEBACK_EVENT(writeback_bdi_register);
DEFINE_WRITEBACK_EVENT(writeback_bdi_unregister);
DEFINE_WRITEBACK_EVENT(writeback_thread_start);
diff --git a/mm/backing-dev.c b/mm/backing-dev.c
index 7cef95e..b4d72d4 100644
--- a/mm/backing-dev.c
+++ b/mm/backing-dev.c
@@ -310,6 +310,7 @@ static void wakeup_timer_fn(unsigned long data)

spin_lock(&bdi->wb_lock);
if (bdi->wb.task) {
+ trace_writeback_wake_thread(bdi);
wake_up_process(bdi->wb.task);
} else {
/*
@@ -317,6 +318,7 @@ static void wakeup_timer_fn(unsigned long data)
* In this case we have to wake-up the forker thread which
* should create and run the bdi thread.
*/
+ trace_writeback_wake_forker_thread(bdi);
wake_up_process(default_backing_dev_info.wb.task);
}
spin_unlock(&bdi->wb_lock);
--
1.7.1.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCHv5 12/15] writeback: optimize periodic bdi thread wakeups
Next: [PATCHv5 06/15] writeback: simplify bdi code a little