PCI: return correct value when writing to the "reset" attribute
in [Kernel]
|
From: Michael S. Tsirkin on 11 May 2010 05:40 On Tue, May 11, 2010 at 11:30:06AM +0200, Michal Schmidt wrote: > A successful write() to the "reset" sysfs attribute should return the > number of bytes written, not 0. Otherwise userspace (bash) retries the > write over and over again. > > Signed-off-by: Michal Schmidt <mschmidt(a)redhat.com> Acked-by: Michael S. Tsirkin <mst(a)redhat.com> > --- > > drivers/pci/pci-sysfs.c | 7 ++++++- > 1 files changed, 6 insertions(+), 1 deletions(-) > > diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c > index fad9398..ba88a2f 100644 > --- a/drivers/pci/pci-sysfs.c > +++ b/drivers/pci/pci-sysfs.c > @@ -960,7 +960,12 @@ static ssize_t reset_store(struct device *dev, > > if (val != 1) > return -EINVAL; > - return pci_reset_function(pdev); > + > + result = pci_reset_function(pdev); > + if (result < 0) > + return result; > + > + return count; > } > > static struct device_attribute reset_attr = __ATTR(reset, 0200, NULL, reset_store); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Michael S. Tsirkin on 11 May 2010 07:10 On Tue, May 11, 2010 at 11:44:54AM +0200, Michal Schmidt wrote: > A successful write() to the "reset" sysfs attribute should return the > number of bytes written, not 0. Otherwise userspace (bash) retries the > write over and over again. > > Signed-off-by: Michal Schmidt <mschmidt(a)redhat.com> Acked-by: Michael S. Tsirkin <mst(a)redhat.com> > --- > > drivers/pci/pci-sysfs.c | 7 ++++++- > 1 files changed, 6 insertions(+), 1 deletions(-) > > diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c > index fad9398..ba88a2f 100644 > --- a/drivers/pci/pci-sysfs.c > +++ b/drivers/pci/pci-sysfs.c > @@ -960,7 +960,12 @@ static ssize_t reset_store(struct device *dev, > > if (val != 1) > return -EINVAL; > - return pci_reset_function(pdev); > + > + result = pci_reset_function(pdev); > + if (result < 0) > + return result; > + > + return count; > } > > static struct device_attribute reset_attr = __ATTR(reset, 0200, NULL, reset_store); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|
Pages: 1 Prev: 2% LOAN OFFER Next: [PATCH] PCI: return correct value when writing to the "reset" attribute |