Patch inclusion in stable
in [Kernel]
|
Prev: ivtv: sizeof() => ARRAY_SIZE()
Next: staging: winbond: mds_f.h whitespace and CamelCase corrections.
From: Surbhi Palande on 18 Mar 2010 07:40 Hi All, I had a look at the 2.6.32.10 stable patches. Had a comment on the 31st patch in the series: commit 7ef79e1045213953b87f45cf5993cc9c70c873ec Author: Stanislaw Gruszka <sgruszka(a)redhat.com> airo: fix setting zero length WEP key The linux-2.6 source has another patch that adds the following line: if (WARN_ON(keylen == 0)) >> + return -1; This is added through the commit 6510b8917948283005a125c8337d3312a8a0561c. This commit is missing in the 2.6.32.10 stable patches. I think it should be a part of stable patches too. Thanks! Warm Regards, Surbhi. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Stanislaw Gruszka on 18 Mar 2010 08:20
On Thu, Mar 18, 2010 at 01:32:33PM +0200, Surbhi Palande wrote: > Hi All, > > I had a look at the 2.6.32.10 stable patches. Had a comment on the 31st > patch in the series: > > commit 7ef79e1045213953b87f45cf5993cc9c70c873ec > Author: Stanislaw Gruszka <sgruszka(a)redhat.com> > > airo: fix setting zero length WEP key > > The linux-2.6 source has another patch that adds the following line: > if (WARN_ON(keylen == 0)) > >> + return -1; > > This is added through the commit > 6510b8917948283005a125c8337d3312a8a0561c. This commit is missing in the > 2.6.32.10 stable patches. I think it should be a part of stable patches > too. keylen == 0 is just bug and should never happen. As we are printing calltrace in such situation user is informed of a bug. Return from function in that case is nice, but not strictly necessary. Cheers Stanislaw -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |