Prev: ahci 0000:00:1f.2: controller reset failed (0xffffffff)
Next: Linux 2.6.34-rc4
From: Konrad Rzeszutek Wilk on 12 Apr 2010 22:30
On Monday 12 April 2010 14:06:18 you wrote:
> From: Mike Christie <michaelc(a)cs.wisc.edu>
>
> This patch just converts the iscsi_ibft module to the
> iscsi boot sysfs lib module.
>
> This patch was made over the ibft-2.6 tree's ibft-1.03 branch:
> http://git.kernel.org/?p=linux/kernel/git/konrad/ibft-2.6.git;a=shortlog;h=
>refs/heads/ibft-1.03
>
> Signed-off-by: Mike Christie <michaelc(a)cs.wisc.edu>
>
I've only two comments:

... snip..
> /*
> + * Helper routiners to check to determine if the entry is valid
> + * in the proper iBFT structure.
> + */
> +static mode_t ibft_check_nic_for(void *data, int type)
> +{
> + struct ibft_kobject *entry = data;
> + struct ibft_nic *nic = entry->nic;
> + mode_t rc = 0;
> +
> + switch (type) {
> + case ISCSI_BOOT_ETH_INDEX:
> + case ISCSI_BOOT_ETH_FLAGS:
> + rc = 1;

Did you mean for that value?
> + break;
> + case ISCSI_BOOT_ETH_IP_ADDR:
> + if (memcmp(nic->ip_addr, nulls, sizeof(nic->ip_addr)))
> + rc = S_IRUGO;
> + break;
> + case ISCSI_BOOT_ETH_SUBNET_MASK:
> + if (nic->subnet_mask_prefix)
> + rc = S_IRUGO;
> + break;
> + case ISCSI_BOOT_ETH_ORIGIN:
> + rc = 1;

and this one as well?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Konrad Rzeszutek Wilk on 12 Apr 2010 22:50
On Monday 12 April 2010 22:32:33 Mike Christie wrote:
> On 04/12/2010 09:21 PM, Konrad Rzeszutek Wilk wrote:
> >> + * Helper routiners to check to determine if the entry is valid
> >> + * in the proper iBFT structure.
> >> + */
> >> +static mode_t ibft_check_nic_for(void *data, int type)
> >> +{
> >> + struct ibft_kobject *entry = data;
> >> + struct ibft_nic *nic = entry->nic;
> >> + mode_t rc = 0;
> >> +
> >> + switch (type) {
> >> + case ISCSI_BOOT_ETH_INDEX:
> >> + case ISCSI_BOOT_ETH_FLAGS:
> >> + rc = 1;
> >
> > Did you mean for that value?
> >
> >> + break;
> >> + case ISCSI_BOOT_ETH_IP_ADDR:
> >> + if (memcmp(nic->ip_addr, nulls, sizeof(nic->ip_addr)))
> >> + rc = S_IRUGO;
> >> + break;
> >> + case ISCSI_BOOT_ETH_SUBNET_MASK:
> >> + if (nic->subnet_mask_prefix)
> >> + rc = S_IRUGO;
> >> + break;
> >> + case ISCSI_BOOT_ETH_ORIGIN:
> >> + rc = 1;
> >
> > and this one as well?
>
> I did not. They should be S_IRUGO. Do you want me to resubmit the
> patches or are you just going to edit those two lines if you merge them?

No need to resend them (unless Peter eyes found something I missed).
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: ahci 0000:00:1f.2: controller reset failed (0xffffffff)
Next: Linux 2.6.34-rc4