Prev: Regulators: wm8400 - cleanup platform driver data handling
Next: [PATCH] security: fix error return path in ima_inode_alloc
From: Mark Brown on 24 Feb 2010 05:30
On Tue, Feb 23, 2010 at 11:38:44PM -0800, Dmitry Torokhov wrote:
> It is a good tone to reset driver data after unbinding the device.

You mean "good style" here. Anyway,

Acked-by: Mark Brown <broonie(a)opensource.wolfsonmicro.com>

BTW, this patch is an example of the sort of stuff I'm talking about
with adding additional changes that aren't documented in the
changelog. As well as nulling out the driver data you're also...

> struct wm8994_ldo {
> int enable;
> - int is_enabled;
> + bool is_enabled;

....doing a conversion to bool here and...

> @@ -276,6 +278,7 @@ static struct platform_driver wm8994_ldo_driver = {
> .remove = __devexit_p(wm8994_ldo_remove),
> .driver = {
> .name = "wm8994-ldo",
> + .owner = THIS_MODULE,
> },

....adding this. The change you mention in the changelog is a single
line edit but with these extra changes the overall diffstat becomes:

> drivers/regulator/wm8994-regulator.c | 11 +++++++----
> 1 files changed, 7 insertions(+), 4 deletions(-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: Regulators: wm8400 - cleanup platform driver data handling
Next: [PATCH] security: fix error return path in ima_inode_alloc