Prev: [PATCH 2/6] change alloc function in pcpu_alloc_pages
Next: linux-ide: hda: possibly failed opcode: 0x25 on Alpha with 2.6.34-rc3
From: Mel Gorman on 13 Apr 2010 11:40
On Wed, Apr 14, 2010 at 12:24:58AM +0900, Minchan Kim wrote:
> alloc_pages calls alloc_pages_node with numa_node_id().
> alloc_pages_node can't see nid < 0.
>
> So we can use alloc_pages_exact_node instead of alloc_pages_node.
> It could avoid comparison and branch as 6484eb3e2a81807722 tried.
>
> Cc: Mel Gorman <mel(a)csn.ul.ie>
> Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu(a)jp.fujitsu.com>
> Signed-off-by: Minchan Kim <minchan.kim(a)gmail.com>

Makes sense.

Signed-off-by: Mel Gorman <mel(a)csn.ul.ie>

> ---
> include/linux/gfp.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/include/linux/gfp.h b/include/linux/gfp.h
> index 4c6d413..b65f003 100644
> --- a/include/linux/gfp.h
> +++ b/include/linux/gfp.h
> @@ -308,7 +308,7 @@ extern struct page *alloc_page_vma(gfp_t gfp_mask,
> struct vm_area_struct *vma, unsigned long addr);
> #else
> #define alloc_pages(gfp_mask, order) \
> - alloc_pages_node(numa_node_id(), gfp_mask, order)
> + alloc_pages_exact_node(numa_node_id(), gfp_mask, order)
> #define alloc_page_vma(gfp_mask, vma, addr) alloc_pages(gfp_mask, 0)
> #endif
> #define alloc_page(gfp_mask) alloc_pages(gfp_mask, 0)
> --
> 1.7.0.5
>

--
Mel Gorman
Part-time Phd Student Linux Technology Center
University of Limerick IBM Dublin Software Lab
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: KAMEZAWA Hiroyuki on 13 Apr 2010 20:10
On Wed, 14 Apr 2010 00:24:58 +0900
Minchan Kim <minchan.kim(a)gmail.com> wrote:

> alloc_pages calls alloc_pages_node with numa_node_id().
> alloc_pages_node can't see nid < 0.
>
> So we can use alloc_pages_exact_node instead of alloc_pages_node.
> It could avoid comparison and branch as 6484eb3e2a81807722 tried.
>
> Cc: Mel Gorman <mel(a)csn.ul.ie>
> Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu(a)jp.fujitsu.com>
> Signed-off-by: Minchan Kim <minchan.kim(a)gmail.com>

Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu(a)jp.fujisu.com>



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH 2/6] change alloc function in pcpu_alloc_pages
Next: linux-ide: hda: possibly failed opcode: 0x25 on Alpha with 2.6.34-rc3