Remove redundant extra_desc info for enum GUC variables?
in [PgSql]
|
Prev: psql wrapped format default for backslash-dcommands
Next: Fairly serious bug induced by latest guc enumchanges
From: Magnus Hagander on 30 Jun 2008 15:58 Tom Lane wrote: > Magnus Hagander <magnus(a)hagander.net> writes: >> Tom Lane wrote: >>> Yeah: LOG level sorts differently in the two cases; it's fairly high >>> priority for server log output and much lower for client output. > >> Ok, easy fix if we break them apart. Should we continue to accept >> values that we're not going to care about, or should I change that at >> the same time? (for example, client_min_messages doesn't use INFO, >> but we do accept that in <= 8.3 anyway) > > I'd be inclined to keep the actual behavior the same as it was. > We didn't document INFO for this variable, perhaps, but it's accepted > and has a well-defined behavior. Sorry for not getting back to this one sooner, it ended up in the wrong end of the queue. Does this patch look like what you meant? It should split them apart, and it also hides the undocumented levels, but still accept it (now that we have the ability to hide GUC vars) //Magnus
From: Tom Lane on 30 Jun 2008 16:25 Magnus Hagander <magnus(a)hagander.net> writes: > Does this patch look like what you meant? It should split them apart, > and it also hides the undocumented levels, but still accept it (now that > we have the ability to hide GUC vars) Seems reasonable, although I'm still dissatisfied with the handling of the "debug" alias for debug2. I think if it's not hidden then it has to be placed in correct sort position. Since it's not documented in config.sgml, I think marking it hidden would be fine. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Magnus Hagander on 30 Jun 2008 16:27
Tom Lane wrote: > Magnus Hagander <magnus(a)hagander.net> writes: >> Does this patch look like what you meant? It should split them apart, >> and it also hides the undocumented levels, but still accept it (now that >> we have the ability to hide GUC vars) > > Seems reasonable, although I'm still dissatisfied with the handling of > the "debug" alias for debug2. I think if it's not hidden then it has > to be placed in correct sort position. Since it's not documented in > config.sgml, I think marking it hidden would be fine. Good point, and thanks for the quick review. Will fix and apply. //Magnus -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers |