Prev: Fwd: [scripts] python: change scripts to use system python instead of env
Next: [PATCHv2 1/2] sched: enable ARCH_POWER
From: Jiri Kosina on 26 Jan 2010 17:50
On Wed, 20 Jan 2010, Shahar Havivi wrote:

> Remove unused fields in drivers/char/vt.c
> variables orig_buf and orig_count are assigned but never used.
> Shahar Havivi

Could you please resend with your Signed-off-by line, as described in
Documentation/SubmittingPatches, so that I could apply the patch?

> ---
> drivers/char/vt.c | 4 ----
> 1 files changed, 0 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/char/vt.c b/drivers/char/vt.c
> index 50faa1f..94f530a 100644
> --- a/drivers/char/vt.c
> +++ b/drivers/char/vt.c
> @@ -2119,8 +2119,6 @@ static int do_con_write(struct tty_struct *tty,
> const unsigned char *buf, int co
> uint8_t inverse;
> uint8_t width;
> u16 himask, charmask;
> - const unsigned char *orig_buf = NULL;
> - int orig_count;
>
> if (in_interrupt())
> return count;
> @@ -2142,8 +2140,6 @@ static int do_con_write(struct tty_struct *tty,
> const unsigned char *buf, int co
> release_console_sem();
> return 0;
> }
> - orig_buf = buf;
> - orig_count = count;
>
> himask = vc->vc_hi_font_mask;
> charmask = himask ? 0x1ff : 0xff;

Thanks,

--
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Shahar Havivi on 27 Jan 2010 03:50
Remove unused fields in drivers/char/vt.c
variables orig_buf and orig_count are assigned but never used.

Signed-off-by: Shahar Havivi <shaharh(a)gmail.com>
---
drivers/char/vt.c | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/drivers/char/vt.c b/drivers/char/vt.c
index 50faa1f..94f530a 100644
--- a/drivers/char/vt.c
+++ b/drivers/char/vt.c
@@ -2119,8 +2119,6 @@ static int do_con_write(struct tty_struct *tty,
const unsigned char *buf, int co
uint8_t inverse;
uint8_t width;
u16 himask, charmask;
- const unsigned char *orig_buf = NULL;
- int orig_count;

if (in_interrupt())
return count;
@@ -2142,8 +2140,6 @@ static int do_con_write(struct tty_struct *tty,
const unsigned char *buf, int co
release_console_sem();
return 0;
}
- orig_buf = buf;
- orig_count = count;

himask = vc->vc_hi_font_mask;
charmask = himask ? 0x1ff : 0xff;
--
1.6.3.3

On Wed, Jan 27, 2010 at 12:43 AM, Jiri Kosina <jkosina(a)suse.cz> wrote:
> On Wed, 20 Jan 2010, Shahar Havivi wrote:
>
>> Remove unused fields in drivers/char/vt.c
>> variables orig_buf and orig_count are assigned but never used.
>> Shahar Havivi
>
> Could you please resend with your Signed-off-by line, as described in
> Documentation/SubmittingPatches, so that I could apply the patch?
>
>> ---
>> �drivers/char/vt.c | � �4 ----
>> �1 files changed, 0 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/char/vt.c b/drivers/char/vt.c
>> index 50faa1f..94f530a 100644
>> --- a/drivers/char/vt.c
>> +++ b/drivers/char/vt.c
>> @@ -2119,8 +2119,6 @@ static int do_con_write(struct tty_struct *tty,
>> const unsigned char *buf, int co
>> � � uint8_t inverse;
>> � � uint8_t width;
>> � � u16 himask, charmask;
>> - � const unsigned char *orig_buf = NULL;
>> - � int orig_count;
>>
>> � � if (in_interrupt())
>> � � � � return count;
>> @@ -2142,8 +2140,6 @@ static int do_con_write(struct tty_struct *tty,
>> const unsigned char *buf, int co
>> � � � � release_console_sem();
>> � � � � return 0;
>> � � }
>> - � orig_buf = buf;
>> - � orig_count = count;
>>
>> � � himask = vc->vc_hi_font_mask;
>> � � charmask = himask ? 0x1ff : 0xff;
>
> Thanks,
>
> --
> Jiri Kosina
> SUSE Labs, Novell Inc.
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Jiri Kosina on 27 Jan 2010 04:20
On Wed, 27 Jan 2010, Shahar Havivi wrote:

> Remove unused fields in drivers/char/vt.c
> variables orig_buf and orig_count are assigned but never used.
>
> Signed-off-by: Shahar Havivi <shaharh(a)gmail.com>
> ---
> drivers/char/vt.c | 4 ----
> 1 files changed, 0 insertions(+), 4 deletions(-)
> diff --git a/drivers/char/vt.c b/drivers/char/vt.c
> index 50faa1f..94f530a 100644
> --- a/drivers/char/vt.c
> +++ b/drivers/char/vt.c
> @@ -2119,8 +2119,6 @@ static int do_con_write(struct tty_struct *tty,
> const unsigned char *buf, int co
> uint8_t inverse;
> uint8_t width;
> u16 himask, charmask;
> - const unsigned char *orig_buf = NULL;
> - int orig_count;
>
> if (in_interrupt())
> return count;
> @@ -2142,8 +2140,6 @@ static int do_con_write(struct tty_struct *tty,
> const unsigned char *buf, int co
> release_console_sem();
> return 0;
> }
> - orig_buf = buf;
> - orig_count = count;
>
> himask = vc->vc_hi_font_mask;
> charmask = himask ? 0x1ff : 0xff;

Your patch is whitespace damaged and line wrapped.

I have fixed it by hand and applied it, but please fix your mail client
for any patch submissions in the future.

Thanks,

--
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: Fwd: [scripts] python: change scripts to use system python instead of env
Next: [PATCHv2 1/2] sched: enable ARCH_POWER