Removing dead CONFIG_PMCTWILED
in [Kernel]
|
Prev: [PATCH] Marvell OpenRD-Ultimate machine support
Next: [PATCH] Fix kernel NULL pointer dereference in dm-mpath.c
From: Shane McDonald on 10 Jun 2010 15:30 On Wed, Jun 9, 2010 at 5:22 AM, Christoph Egger <siccegge(a)cs.fau.de> wrote: > CONFIG_PMCTWILED doesn't exist in Kconfig, therefore removing all > references for it from the source code. > > Signed-off-by: Christoph Egger <siccegge(a)cs.fau.de> > --- > �arch/mips/pmc-sierra/msp71xx/msp_hwbutton.c | � 11 ----------- > �1 files changed, 0 insertions(+), 11 deletions(-) > > diff --git a/arch/mips/pmc-sierra/msp71xx/msp_hwbutton.c b/arch/mips/pmc-sierra/msp71xx/msp_hwbutton.c > index 11769b5..c841f08 100644 > --- a/arch/mips/pmc-sierra/msp71xx/msp_hwbutton.c > +++ b/arch/mips/pmc-sierra/msp71xx/msp_hwbutton.c > @@ -32,9 +32,6 @@ > �#include <msp_int.h> > �#include <msp_regs.h> > �#include <msp_regops.h> > -#ifdef CONFIG_PMCTWILED > -#include <msp_led_macros.h> > -#endif > > �/* For hwbutton_interrupt->initial_state */ > �#define HWBUTTON_HI � �0x1 > @@ -82,10 +79,6 @@ static void standby_on(void *data) > � � � �printk(KERN_WARNING "STANDBY switch was set to ON (not implemented)\n"); > > � � � �/* TODO: Put board in standby mode */ > -#ifdef CONFIG_PMCTWILED > - � � � msp_led_turn_off(MSP_LED_PWRSTANDBY_GREEN); > - � � � msp_led_turn_on(MSP_LED_PWRSTANDBY_RED); > -#endif > �} > > �static void standby_off(void *data) > @@ -94,10 +87,6 @@ static void standby_off(void *data) > � � � � � � � �"STANDBY switch was set to OFF (not implemented)\n"); > > � � � �/* TODO: Take out of standby mode */ > -#ifdef CONFIG_PMCTWILED > - � � � msp_led_turn_on(MSP_LED_PWRSTANDBY_GREEN); > - � � � msp_led_turn_off(MSP_LED_PWRSTANDBY_RED); > -#endif > �} > > �static struct hwbutton_interrupt softreset_sw = { > -- > 1.6.3.3 This constant was added in a patch that was never accepted: http://www.linux-mips.org/archives/linux-mips/2007-03/msg00421.html. Because this patch was submitted over 3 years ago, I think it's reasonable to assume that work on the patch has stalled, and so I think removing the CONFIG_PMCTWILED constant makes sense. I seem to be the only person semi-actively doing anything with the MSP7120 code base, so if I ever try to clean up the patch and re-submit, I'll re-submit the changes being removed in this patch. Acked-by: Shane McDonald <mcdonald.shane(a)gmail.com> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Ralf Baechle on 5 Jul 2010 05:20
On Thu, Jun 10, 2010 at 01:24:08PM -0600, Shane McDonald wrote: > On Wed, Jun 9, 2010 at 5:22 AM, Christoph Egger <siccegge(a)cs.fau.de> wrote: > > CONFIG_PMCTWILED doesn't exist in Kconfig, therefore removing all > > references for it from the source code. > > > > Signed-off-by: Christoph Egger <siccegge(a)cs.fau.de> Queued for 2.6.26. Thanks, Ralf -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |