From: Américo Wang on
On Thu, Apr 08, 2010 at 05:10:06PM +0200, Heiko Carstens wrote:
>From: Heiko Carstens <heiko.carstens(a)de.ibm.com>
>
>Revert ba168fc37dea145deeb8fa9e7e71c748d2e00d74 "memory-hotplug: add 0x prefix
>to HEX block_size_bytes" since it changes the user space visible sysfs interface
>/sys/devices/system/memory/block_size_bytes.
>The change breaks existing user space applications which rely on the fact that
>the output does not contain the "0x" prefix.
>

Odd.

Which application relies on this? Isn't the application which should
be fixed?? It should use something like strtoul() which doesn't
rely on '0x' prefix.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Wu Fengguang on
Hi Heiko,

On Fri, Apr 09, 2010 at 05:29:18AM +0800, Heiko Carstens wrote:
> On Thu, Apr 08, 2010 at 11:41:24PM +0800, Américo Wang wrote:
> > On Thu, Apr 08, 2010 at 05:10:06PM +0200, Heiko Carstens wrote:
> > >From: Heiko Carstens <heiko.carstens(a)de.ibm.com>
> > >
> > >Revert ba168fc37dea145deeb8fa9e7e71c748d2e00d74 "memory-hotplug: add 0x prefix
> > >to HEX block_size_bytes" since it changes the user space visible sysfs interface
> > >/sys/devices/system/memory/block_size_bytes.
> > >The change breaks existing user space applications which rely on the fact that
> > >the output does not contain the "0x" prefix.
> >
> > Odd.
> >
> > Which application relies on this? Isn't the application which should
> > be fixed?? It should use something like strtoul() which doesn't
> > rely on '0x' prefix.
>
> Ok, consider it the other way round: your application is doing strtoul()
> with a base of 0 (since you rely on the 0x prefix) and for no good reason
> it doesn't work on older kernels.
> I really can't see a reason for adding additional pitfalls by _changing_
> a long existing user space interface.

Ack to revert it. Sorry for killing your time!

Thanks,
Fengguang
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Pavel Machek on
On Thu 2010-04-08 23:41:24, Am?rico Wang wrote:
> On Thu, Apr 08, 2010 at 05:10:06PM +0200, Heiko Carstens wrote:
> >From: Heiko Carstens <heiko.carstens(a)de.ibm.com>
> >
> >Revert ba168fc37dea145deeb8fa9e7e71c748d2e00d74 "memory-hotplug: add 0x prefix
> >to HEX block_size_bytes" since it changes the user space visible sysfs interface
> >/sys/devices/system/memory/block_size_bytes.
> >The change breaks existing user space applications which rely on the fact that
> >the output does not contain the "0x" prefix.
> >
>
> Odd.
>
> Which application relies on this? Isn't the application which should
> be fixed?? It should use something like strtoul() which doesn't
> rely on '0x' prefix.

'no regressions'?!

You should not randomly change kernel api, then blame it on applications.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/